Loop Bug

[suhanmoon]

Fixed a bug when moving left or right when setting loop={true}

Platforms affected

all

What does this PR do?

loop bug fix

What testing has been done on this change?

Set to loop true.
Moving to the left immediately after loading, moving to the right, moving as animation.

Tested features checklist

• Default setup (example)
• Carousels with and without momentum enabled (prop enableMomentum)
• Vertical carousels (prop vertical)
• Slide alignment (prop activeSlideAlignment)
• Autoplay (prop autoplay)
• Loop mode (prop loop)
• ScrollView/FlatList carousels (prop useScrollView)
• Callback methods
• ParallaxImage component
• Pagination component
• Layouts and custom interpolations

[bd-arc]

Hi @suhanmoon,

Thanks for the PR!

To be honest, I do see how this fix is supposed to help with the loop issue. Could you please elaborate on that a little further?

[suhanmoon]

This Full width, 3 items set.

1. Left-to-Right Swipe
2. Move to the back (Animated) after swiping.

[oliverdolgener]

I can confirm this fixes the issue that causes a scroll animation to be played when loop is enabled and the user swipes to the right (to reach the last item) or to the left (to reach the first item) immediately after the component has been mounted.

[zabojad]

@bd-arc I also confirm it fixes the issue we have in loop mode with the animation being played after reaching a cloned item.

[zabojad]

In my opinion, we should even have this on line 274:

this._snapToItem(nextFirstItem, false, false, false, false);

No need to trigger the callbacks again...

[bd-arc]

Available in version 3.8.0.

[Saad9624]

comment out this line under Crousel.js
return this._carouselRef && this._carouselRef.getNode && this._carouselRef.getNode();

Thanks me later!