refactor(update): use iterators instead channels#91
Closed
lucarin91 wants to merge 3 commits intoarduino:mainfrom
Closed
refactor(update): use iterators instead channels#91lucarin91 wants to merge 3 commits intoarduino:mainfrom
lucarin91 wants to merge 3 commits intoarduino:mainfrom
Conversation
lucarin91
force-pushed
the
update-use-iterators
branch
from
81b2b52 to
6b20319
Compare
lucarin91
changed the title
Member
|
Why not using a callback instead? func (s *Service) UpgradePackages(ctx context.Context, names []string, eventCB func (ev update.Event)) error {
....
eventCB(....)
....
} |
5 tasks
Member
|
Here an alternative with callbacks: #176 |
Contributor
Author
|
superseded by #176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I would prefer to use iterator when possible, following the approach we use in other part of the code base.
Change description
Additional Notes
Reviewer checklist
main.