Skip to content

Comments

Use the refactored CLI in IDE#1310

Merged
kittaakos merged 1 commit intomainfrom
discovery-cli
Aug 15, 2022
Merged

Use the refactored CLI in IDE#1310
kittaakos merged 1 commit intomainfrom
discovery-cli

Conversation

@kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Aug 9, 2022 •
edited by per1234
Loading

Motivation

The IDE uses a CLI from the test_1 branch from the arduino owner.

Screen Shot 2022-08-11 at 10 11 03

Screen Shot 2022-08-11 at 10 16 31

Change description

No code changes. The IDE uses the CLI from the HEAD of this branch.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement status: on hold Do not proceed at this time topic: CLI Related to Arduino CLI labels Aug 9, 2022
@kittaakos kittaakos force-pushed the discovery-cli branch 3 times, most recently from 557661c to 2544b9a Compare August 10, 2022 12:12
@kittaakos kittaakos mentioned this pull request Aug 10, 2022
Merged
4 tasks
@kittaakos kittaakos force-pushed the discovery-cli branch 2 times, most recently from a87ac91 to 1f98579 Compare August 11, 2022 08:19
@kittaakos kittaakos marked this pull request as ready for review August 11, 2022 08:19
@kittaakos kittaakos changed the title Use the refectored CLI in IDE2. Use the refactored CLI in IDE2 Aug 11, 2022
Use the refactored CLI in IDE2.
f2dda8d 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
per1234
per1234 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not had any problems while testing this PR, so it does not appear that there are any problems with the changes made in this version of Arduino CLI.

@kittaakos kittaakos merged commit 8b3f3c6 into main Aug 15, 2022
@kittaakos kittaakos deleted the discovery-cli branch August 15, 2022 07:19
@per1234 per1234 mentioned this pull request Aug 18, 2022
Closed
3 tasks
@per1234 per1234 changed the title Use the refactored CLI in IDE2 Use the refactored CLI in IDE Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

No one assigned

Labels

status: on hold Do not proceed at this time topic: CLI Related to Arduino CLI type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kittaakos @per1234