Merge from 4.x: PR spyder-ide#12792

Fixes spyder-ide#12572
Fixes spyder-ide#12333

Author: ccordoba12

.pep8speaks.yml

@@ -1,4 +1,6 @@
-# File : .pep8speaks.yml
-
 scanner:
     diff_only: True  # Errors caused by only the patch are shown
+    linter: pycodestyle
+
+pycodestyle:
+    exclude: external-deps

binder/environment.yml

@@ -15,12 +15,12 @@ dependencies:
 - diff-match-patch >=20181111
 - intervaltree
 - ipython >=4.0
-- jedi =0.15.2
+- jedi =0.17.0
 - keyring
 - nbconvert >=4.0
 - numpydoc >=0.6.0
 - paramiko >=2.4.0
-- parso =0.5.2
+- parso =0.7.0
 - pexpect >=4.4.0
 - pickleshare >=0.4
 - psutil >=5.3

external-deps/python-language-server/.circleci/config.yml

@@ -14,7 +14,7 @@ jobs:
 
   python3-test:
     docker:
-      - image: "python:3.5-stretch"
+      - image: "python:3.6-stretch"
     steps:
       - checkout
       # To test Jedi environments
@@ -35,7 +35,7 @@ jobs:
 
   publish:
     docker:
-      - image: "python:3.5-stretch"
+      - image: "python:3.6-stretch"
     steps:
       - checkout
       - run: ./scripts/circle/pypi.sh

external-deps/python-language-server/.gitrepo

@@ -6,7 +6,7 @@
 [subrepo]
 	remote = https://github.com/palantir/python-language-server.git
 	branch = develop
-	commit = fdb8b3dbc5df7d12729d135932bf2264e0883061
-	parent = 0798ff6e51f6d1c353b8278469a32adab54b874f
+	commit = 9b5cb2197405b2290161deb2abd8e2b139a53691
+	parent = dbb0398cd7e309e6de7a7740c57a03ecbb26ac11
 	method = merge
 	cmdver = 0.4.1

external-deps/python-language-server/README.rst

@@ -72,6 +72,10 @@ To enable pydocstyle for linting docstrings add the following setting in your LS
 "pyls.plugins.pydocstyle.enabled": true
 ```
 
+See `vscode-client/package.json`_ for the full set of supported configuration options.
+
+.. _vscode-client/package.json: vscode-client/package.json
+
 Language Server Features
 ------------------------
 

external-deps/python-language-server/appveyor.yml

@@ -6,8 +6,8 @@ environment:
       PYTHON_VERSION: "2.7.15"
       PYTHON_ARCH: "64"
 
-    - PYTHON: "C:\\Python35"
-      PYTHON_VERSION: "3.5.7"
+    - PYTHON: "C:\\Python36"
+      PYTHON_VERSION: "3.6.8"
       PYTHON_ARCH: "64"
 
 matrix:

external-deps/python-language-server/pyls/_utils.py

@@ -1,5 +1,4 @@
 # Copyright 2017 Palantir Technologies, Inc.
-from distutils.version import LooseVersion
 import functools
 import inspect
 import logging
@@ -140,18 +139,34 @@ def format_docstring(contents):
     """
     contents = contents.replace('\t', u'\u00A0' * 4)
     contents = contents.replace('  ', u'\u00A0' * 2)
-    if LooseVersion(JEDI_VERSION) < LooseVersion('0.15.0'):
-        contents = contents.replace('*', '\\*')
     return contents
 
 
 def clip_column(column, lines, line_number):
-    # Normalise the position as per the LSP that accepts character positions > line length
-    # https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#position
+    """
+    Normalise the position as per the LSP that accepts character positions > line length
+
+    https://microsoft.github.io/language-server-protocol/specification#position
+    """
     max_column = len(lines[line_number].rstrip('\r\n')) if len(lines) > line_number else 0
     return min(column, max_column)
 
 
+def position_to_jedi_linecolumn(document, position):
+    """
+    Convert the LSP format 'line', 'character' to Jedi's 'line', 'column'
+
+    https://microsoft.github.io/language-server-protocol/specification#position
+    """
+    code_position = {}
+    if position:
+        code_position = {'line': position['line'] + 1,
+                         'column': clip_column(position['character'],
+                                               document.lines,
+                                               position['line'])}
+    return code_position
+
+
 if os.name == 'nt':
     import ctypes
 

external-deps/python-language-server/pyls/config/pycodestyle_conf.py

@@ -15,6 +15,7 @@
     ('ignore', 'plugins.pycodestyle.ignore', list),
     ('max-line-length', 'plugins.pycodestyle.maxLineLength', int),
     ('select', 'plugins.pycodestyle.select', list),
+    ('aggressive', 'plugins.pycodestyle.aggressive', int),
 ]
 
 

external-deps/python-language-server/pyls/lsp.py

@@ -24,6 +24,13 @@ class CompletionItemKind(object):
     Color = 16
     File = 17
     Reference = 18
+    Folder = 19
+    EnumMember = 20
+    Constant = 21
+    Struct = 22
+    Event = 23
+    Operator = 24
+    TypeParameter = 25
 
 
 class DocumentHighlightKind(object):

external-deps/python-language-server/pyls/plugins/autopep8_format.py

@@ -57,6 +57,7 @@ def _autopep8_config(config):
         'ignore': settings.get('ignore'),
         'max_line_length': settings.get('maxLineLength'),
         'select': settings.get('select'),
+        'aggressive': settings.get('aggressive'),
     }
 
     # Filter out null options