Skip to content

Commit 728228d

Browse files
committed
Merge from 4.x: PR spyder-ide#11854
2 parents df78469 + 5562056 commit 728228d

7 files changed

Lines changed: 17 additions & 18 deletions

File tree

binder/environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ dependencies:
2727
- pylint >=0.25
2828
- pyqt <5.13
2929
- pyyaml
30-
- python-language-server >=0.31.2,<0.32.0
30+
- python-language-server >=0.31.9,<0.32.0
3131
- pyxdg >=0.26
3232
- pyzmq >=17
3333
- qdarkstyle >=2.8

continuous_integration/azure/install.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ if [ "$USE_CONDA" = "yes" ]; then
2424

2525
# Install python-language-server from Github with no deps
2626
pip install -q --no-deps git+https://github.com/palantir/python-language-server
27-
28-
# Avoid problems with wrong jupyter_client version being picked up
29-
if [ "$PYTHON_VERSION" = "2.7" ]; then
30-
conda install -q -y jupyter_client=5.3.4
31-
fi
3227
else
3328
# Github backend tests are failing with 1.1.1d
3429
conda install -q -y openssl=1.1.1c

continuous_integration/travis/install.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ if [ "$USE_CONDA" = "yes" ]; then
3939

4040
# Install python-language-server from Github with no deps
4141
pip install -q --no-deps git+https://github.com/palantir/python-language-server
42-
43-
# Avoid problems with wrong jupyter_client version being picked up
44-
if [ "$PYTHON_VERSION" = "2.7" ]; then
45-
conda install -q -y jupyter_client=5.3.4
46-
fi
4742
else
4843
# Downgrade to Python 3.7.3 because 3.7.4 is not pulling
4944
# wheels for all packages

requirements/conda.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ psutil >=5.3
2121
pygments >=2.0
2222
pylint >=0.25
2323
pyqt <5.13
24-
python-language-server >=0.31.2,<0.32.0
24+
# There's no need to set a version for python-language-server
25+
# because we install it from master for our tests.
26+
python-language-server
2527
pyxdg >=0.26
2628
pyzmq >=17
2729
qdarkstyle >=2.8

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ def run(self):
226226
'pylint>=0.25',
227227
'pyqt5<5.13;python_version>="3"',
228228
'pyqtwebengine<5.13;python_version>="3"',
229-
'python-language-server[all]>=0.31.2,<0.32.0',
229+
'python-language-server[all]>=0.31.9,<0.32.0',
230230
'pyxdg>=0.26;platform_system=="Linux"',
231231
'pyzmq>=17',
232232
'qdarkstyle>=2.8',

spyder/dependencies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
PSUTIL_REQVER = '>=5.3'
4848
PYGMENTS_REQVER = '>=2.0'
4949
PYLINT_REQVER = '>=0.25'
50-
PYLS_REQVER = '>=0.31.2;<0.32.0'
50+
PYLS_REQVER = '>=0.31.9;<0.32.0'
5151
PYXDG_REQVER = '>=0.26'
5252
PYZMQ_REQVER = '>=17'
5353
QDARKSTYLE_REQVER = '>=2.8'

spyder/tests/test_dependencies_in_sync.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,11 @@ def test_dependencies_for_binder_in_sync():
205205
if 'pytest-xvfb' in spyder_env:
206206
spyder_env.pop('pytest-xvfb')
207207

208+
# There's no need to test for this because we install it
209+
# from master in some cases.
210+
for req in [spyder_env, spyder_reqs]:
211+
req.pop('python-language-server')
212+
208213
# Check that the requirement files match the environment yaml file
209214
full_reqs = {}
210215
full_reqs.update(test_reqs)
@@ -220,10 +225,11 @@ def test_dependencies_for_spyder_dialog_in_sync():
220225
spyder_deps = parse_spyder_dependencies()
221226
spyder_reqs = parse_requirements(REQ_FPATH)
222227

223-
# No need to check for spyder-kernels because we're using
224-
# a subrepo for it in some cases
228+
# No need to check for these deps because either we're using
229+
# a subrepo for them or we're installing them from master.
225230
for req in [spyder_deps, spyder_reqs]:
226231
req.pop('spyder-kernels')
232+
req.pop('python-language-server')
227233

228234
if 'pyqt' in spyder_reqs:
229235
spyder_reqs.pop('pyqt')
@@ -245,10 +251,11 @@ def test_dependencies_for_spyder_setup_install_requires_in_sync():
245251
spyder_setup = parse_setup_install_requires(SETUP_FPATH)
246252
spyder_reqs = parse_requirements(REQ_FPATH)
247253

248-
# No need to check for spyder-kernels because we're using
249-
# a subrepo for it in some cases
254+
# No need to check for these deps because either we're using
255+
# a subrepo for them or we're installing them from master.
250256
for req in [spyder_reqs, spyder_setup]:
251257
req.pop('spyder-kernels')
258+
req.pop('python-language-server')
252259

253260
# rtree is only available through conda
254261
if 'rtree' in spyder_reqs:

0 commit comments

Comments
 (0)