-
Notifications
You must be signed in to change notification settings - Fork 2
Droid AI chat surface #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
948202e
refactor(chat): extract shared ACP host client for CLI pools
cursoragent 2c05873
feat(chat): add Factory Droid ACP work chat surface
cursoragent 2a3fb16
fix(acp): dedupe pool refs, pending init, process eviction, terminal …
cursoragent 5fcbe4e
fix(droid): PR review — executable order, auth, interrupts, UI copy
cursoragent d5f1144
fix(droid): auth probe verified flags; resolveDroid path; setup/turn …
cursoragent e280345
fix(acp): bounded acquire retries; clear waitForTerminalExit kill tim…
cursoragent 19bd938
fix: auth probe, pool generation guards, root path, double-release, a…
arul28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import type { DetectedAuth } from "./authDetector"; | ||
| import { resolveExecutableFromKnownLocations } from "./cliExecutableResolver"; | ||
|
|
||
| export type DroidExecutableResolution = { | ||
| path: string; | ||
| source: "auth" | "path" | "common-dir" | "fallback-command"; | ||
| }; | ||
|
|
||
| function findDroidAuthPath(auth?: DetectedAuth[]): string | null { | ||
| for (const entry of auth ?? []) { | ||
| if (entry.type !== "cli-subscription" || entry.cli !== "droid") continue; | ||
| const candidate = entry.path.trim(); | ||
| if (candidate) return candidate; | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| /** Resolves the Factory Droid CLI binary (`droid`). */ | ||
| export function resolveDroidExecutable(args?: { | ||
| auth?: DetectedAuth[]; | ||
| env?: NodeJS.ProcessEnv; | ||
| }): DroidExecutableResolution { | ||
| const env = args?.env ?? process.env; | ||
|
|
||
| const envPath = env.DROID_EXECUTABLE?.trim() || env.FACTORY_DROID_EXECUTABLE?.trim(); | ||
| if (envPath) { | ||
| return { path: envPath, source: "path" }; | ||
| } | ||
|
|
||
| const authPath = findDroidAuthPath(args?.auth); | ||
| if (authPath) { | ||
| return { path: authPath, source: "auth" }; | ||
| } | ||
|
|
||
| const resolved = resolveExecutableFromKnownLocations("droid", env); | ||
| if (resolved) { | ||
| return { | ||
| path: resolved.path, | ||
| source: resolved.source === "path" ? "path" : "common-dir", | ||
| }; | ||
| } | ||
|
|
||
| return { path: "droid", source: "fallback-command" }; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.