Return SendError from Sender::send on disconnect.#901
Closed
cmaves wants to merge 3 commits intoasync-rs:masterfrom
cmaves:master
Closed
Return SendError from Sender::send on disconnect.#901cmaves wants to merge 3 commits intoasync-rs:masterfrom cmaves:master
cmaves wants to merge 3 commits intoasync-rs:masterfrom
cmaves:master
Conversation
Member
|
Superseded by #915 I guess? |
Author
|
Yeah, that PR negates the need for this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
sendmethod forSender<T>returns a Future that never finishes if the channel is disconnected. This issue was brought up and this fix was proposed in issue #880.This changes brings the
sendmethod more inline with what the standard library's sender structs do, where they return an error on disconnect.If this pull request's fix isn't appropriate then hopefully it can at least get the ball rolling on something else.