tests: move the test to modules/common.py

Author: aweits

lib/spack/spack/test/install.py

@@ -16,7 +16,6 @@
 import spack.store
 from spack.spec import Spec
 from spack.package import _spack_build_envfile, _spack_build_logfile
-import spack.modules.common
 
 
 def test_install_and_uninstall(install_mockery, mock_fetch, monkeypatch):
@@ -40,8 +39,6 @@ def find_nothing(*args):
         with pytest.raises(spack.repo.UnknownPackageError):
             spec.package
 
-        module_path = spack.modules.common.get_module('tcl', spec, True)
-        assert module_path
         pkg.do_uninstall()
     except Exception:
         pkg.remove_prefix()

lib/spack/spack/test/modules/common.py

@@ -11,6 +11,7 @@
 import spack.spec
 import spack.modules.tcl
 from spack.modules.common import UpstreamModuleIndex
+from spack.spec import Spec
 
 import spack.error
 
@@ -183,3 +184,31 @@ def test_get_module_upstream():
         assert m1_path == '/path/to/a'
     finally:
         spack.modules.common.upstream_module_index = old_index
+
+def test_load_installed_package_not_in_repo(install_mockery, mock_fetch, monkeypatch):
+    # Get a basic concrete spec for the trivial install package.
+    spec = Spec('trivial-install-test-package')
+    spec.concretize()
+    assert spec.concrete
+
+    # Get the package
+    pkg = spec.package
+
+    def find_nothing(*args):
+        raise spack.repo.UnknownPackageError(
+            'Repo package access is disabled for test')
+
+    try:
+        pkg.do_install()
+
+        spec._package = None
+        monkeypatch.setattr(spack.repo, 'get', find_nothing)
+        with pytest.raises(spack.repo.UnknownPackageError):
+            spec.package
+
+        module_path = spack.modules.common.get_module('tcl', spec, True)
+        assert module_path
+        pkg.do_uninstall()
+    except Exception:
+        pkg.remove_prefix()
+        raise