feat(idempotent): Include function name in the idempotent key#326
Merged
heitorlessa merged 9 commits intoMar 12, 2021
Merged
Conversation
Contributor
Author
|
@heitorlessa what do you think of this ? |
Nr18
reviewed
Mar 11, 2021
Co-authored-by: Joris Conijn <jco@woodwing.com>
Co-authored-by: Joris Conijn <jco@woodwing.com>
heitorlessa
suggested changes
Mar 12, 2021
Contributor
heitorlessa
left a comment
There was a problem hiding this comment.
Great, thanks!!! Only change here is that we shouldn't add this extra parameter to include function_name, but make it the default.
Because we're in Beta this won't cause any distress, and due to the fact changing a Function name is not possible from an API perspective - IaC triggers a replacement instead.
heitorlessa
reviewed
Mar 12, 2021
heitorlessa
approved these changes
Mar 12, 2021
Contributor
There was a problem hiding this comment.
Thanks a lot for the changes @michaelbrewer, as always ;)
Added a note to update docs to emphasize you can now use a single DDB table to store idempotence state if you wish
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#318
Description of changes:
Prefix the
hashed_idempotency_keywith the context function name:f"{context.function_name}#{self._generate_hash(data)}"HOWEVER: You MIGHT get edge cases where the function name has been changed while keeping an existing datastore
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.