Skip to content

Latest commit

 

History

History
98 lines (62 loc) · 4.29 KB

CONTRIBUTING.md

File metadata and controls

98 lines (62 loc) · 4.29 KB

Contributing Guidelines

Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional documentation, we greatly value feedback and contributions from our community.

Please read through this document before submitting any issues or pull requests to ensure we have all the necessary information to effectively respond to your bug report or contribution.

Reporting Bugs/Feature Requests

We welcome you to use the GitHub issue tracker to report bugs or suggest features.

When filing an issue, please check existing open, or recently closed, issues to make sure somebody else hasn't already reported the issue. Please try to include as much information as you can. Details like these are incredibly useful:

  • A reproducible test case or series of steps
  • The version of our code being used
  • Any modifications you've made relevant to the bug
  • Anything unusual about your environment or deployment

Contributing via Pull Requests

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. You are working against the latest source on the main branch.
  2. You check existing open, and recently merged, pull requests to make sure someone else hasn't addressed the problem already.
  3. You open an issue to discuss any significant work - we would hate for your time to be wasted.

To send us a pull request, please:

  1. Fork the repository.
  2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  3. Ensure local tests pass.
  4. Commit to your fork using clear commit messages.
  5. Send us a pull request, answering any default questions in the pull request interface.
  6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

GitHub provides additional document on forking a repository and creating a pull request.

Finding contributions to work on

Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels (enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any 'help wanted' issues is a great place to start.

Blueprint Testing

When creating or modifying blueprints, include a test.sh script that validates the blueprint works as documented in its README. This helps with maintenance and ensures blueprints continue to work as Karpenter evolves.

Running Tests

Use the Makefile to run blueprint tests:

# Set required environment variables first
export CLUSTER_NAME=$(terraform -chdir=cluster/terraform output -raw cluster_name)
export KARPENTER_NODE_IAM_ROLE_NAME=$(terraform -chdir=cluster/terraform output -raw node_instance_role_name)

# Run all blueprint tests
make test

# Run tests for a specific blueprint
make test-node-overlay
# or
make test BLUEPRINT=node-overlay

# List blueprints that have tests
make list-blueprints

# Check environment variable status
make env

Using Kiro for Blueprint Development

If you're using Kiro, you can leverage the blueprint testing steering file to help create test scripts:

  1. Open the blueprint you're working on
  2. Reference #blueprint-testing in your Kiro chat to load the testing guidelines
  3. Ask Kiro to help create a test script based on your blueprint's README

See blueprints/node-overlay/test.sh for a reference implementation.

Code of Conduct

This project has adopted the Amazon Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opensource-codeofconduct@amazon.com with any additional questions or comments.

Security issue notifications

If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our vulnerability reporting page. Please do not create a public github issue.

Licensing

See the LICENSE file for our project's licensing. We will ask you to confirm the licensing of your contribution.