Skip to content

Conversation

@valerena
Copy link
Contributor

@valerena valerena commented Jul 8, 2021

Which issue(s) does this change fix?

Why is this change necessary?

Consume the latest version of RIE

How does it address the issue?

It bring the latest version of RIE

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jfuss
jfuss previously approved these changes Jul 8, 2021
@mgrandis mgrandis changed the title New release of RIE: 1.1 chore: Update RIE binary to 1.1 Jul 8, 2021
@jfuss jfuss dismissed their stale review August 25, 2021 13:43

We have seen problems with this pr locally. Revoking until we understand what the cause is.

Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific requests but we have seen problems with the new rie when trying this locally. We don't yet understand why. Requesting changes to mark this as "do not merge".

@jfuss
Copy link
Contributor

jfuss commented Aug 31, 2021

Closing in favor of #3216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants