fix(clients): export explicit dependencies on @aws-sdk/types#1902
Merged
alexforsyth merged 3 commits intoaws:masterfrom Jan 12, 2021
Merged
fix(clients): export explicit dependencies on @aws-sdk/types#1902alexforsyth merged 3 commits intoaws:masterfrom
alexforsyth merged 3 commits intoaws:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1902 +/- ##
==========================================
+ Coverage 79.30% 79.83% +0.52%
==========================================
Files 368 368
Lines 15132 15551 +419
Branches 3222 3367 +145
==========================================
+ Hits 12001 12415 +414
- Misses 3131 3136 +5
Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
Jan 12, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1842
Codegen: smithy-lang/smithy-typescript#262
Description of changes:
Packages that depend on @aws-sdk/types should explicitly call out that dependency so that downstream consumers get type support out of the box and do not have to install their own version of @aws-sdk/types . This PR should do that for all packages that depend on @aws-sdk/types in AWS sdk v3.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.