feat(clients): remove generated log filters for data with no sensitive data#4544
Merged
feat(clients): remove generated log filters for data with no sensitive data#4544
Conversation
3 tasks
kuhe
force-pushed
the
feat/data-filter
branch
3 times, most recently
from
16af73b to
dcc1428
Compare
kuhe
force-pushed
the
feat/data-filter
branch
4 times, most recently
from
bb0c990 to
585821b
Compare
MYoung25
approved these changes
Mar 22, 2023
trivikr
approved these changes
Mar 22, 2023
2 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
smithy-lang/smithy-typescript#722
Description
Codegen for the Smithy change above, to remove filtering functions that do nothing to save on generated code size.
Note: the first commit contains a sample single-client diff. The following commits contain the rest of codegen changes.
Testing