fix: rootNode.getAllContext() returns empty object #2483
Merged
Conversation
nvinson
changed the title
nvinson
force-pushed
the
10.x
branch
6 times, most recently
from
5d61f05 to
1c71455
Compare
Correct getAllContext() to return the root node's context in addition to specified defaults. Closes: aws#2239 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
mrgrain
changed the title
mrgrain
reviewed
Oct 10, 2024
mrgrain
reviewed
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct getAllContext() to return the root node's context in addition to specified defaults.
Fixes: #2239