diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index bd2105f9..0d32b02d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -14,22 +14,17 @@ -## Unit test coverage - -- [ ] All new/modified code has unit tests -- [ ] Coverage verified for changed code -- [ ] N/A - no testable code changes - -## Do we need integration tests? - -- [ ] Yes - integration tests added -- [ ] No - unit tests sufficient -- [ ] No - infrastructure/config change only -- [ ] Unsure - please advise - ---- - -## Checklist -- [ ] PR title clearly describes the change -- [ ] No sensitive information exposed and security is maintained -- [ ] Ready for review \ No newline at end of file +## Are unit tests added? + + +## Are integration tests added? + + +## Reviewer Guidelines + +‼️ **Merge Requirements**: PRs with failing integration tests cannot be merged without justification. + +One of the following must be true: +- [ ] All automated PR checks pass +- [ ] Failed tests include local run results/screenshots proving they work +- [ ] Changes are documentation-only \ No newline at end of file diff --git a/.gitignore b/.gitignore index c6fd50da..2aeb3d4b 100644 --- a/.gitignore +++ b/.gitignore @@ -22,7 +22,11 @@ doc/_build/ /sagemaker-hyperpod/build /sagemaker-hyperpod/.coverage /sagemaker-hyperpod/.coverage.* + /hyperpod-cluster-stack-template/build +/hyperpod-pytorch-job-template/build +/hyperpod-custom-inference-template/build +/hyperpod-jumpstart-inference-template/build # Ignore all contents of result and results directories /result/ diff --git a/README.md b/README.md index d2f8aaf5..1255c165 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,7 @@ hyp list-cluster |--------|------|-------------| | `--region ` | Optional | The region that the SageMaker HyperPod and EKS clusters are located. If not specified, it will be set to the region from the current AWS account credentials. | | `--namespace ` | Optional | The namespace that users want to check the quota with. Only the SageMaker managed namespaces are supported. | -| `--output ` | Optional | The output format. Available values are `table` and `json`. The default value is `json`. | +| `--output ` | Optional | The output format. Available values are `table` and `json`. The default value is `json`. | | `--debug` | Optional | Enable debug mode for detailed logging. | ### Connecting to a Cluster