From df339cfc9a9f1d5c2cbe777ea6ed26b47507c8a7 Mon Sep 17 00:00:00 2001 From: jzhaoqwa <52220743+zhaoqizqwang@users.noreply.github.com> Date: Tue, 9 Sep 2025 23:18:49 -0700 Subject: [PATCH 1/5] Update PR template --- .github/pull_request_template.md | 27 +++++++++++---------------- .gitignore | 4 ++++ 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index bd2105f9..4cf7861a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -14,22 +14,17 @@ -## Unit test coverage - -- [ ] All new/modified code has unit tests -- [ ] Coverage verified for changed code -- [ ] N/A - no testable code changes - -## Do we need integration tests? - -- [ ] Yes - integration tests added -- [ ] No - unit tests sufficient -- [ ] No - infrastructure/config change only -- [ ] Unsure - please advise +## Are unit tests added? + + +## Are integration tests added? + --- -## Checklist -- [ ] PR title clearly describes the change -- [ ] No sensitive information exposed and security is maintained -- [ ] Ready for review \ No newline at end of file +## Reviewer Guidelines +‼️ **Integration Test Policy**: PRs with failing integration tests cannot be merged without justification +‼️ **Merge Requirements** - One of the following must be true: +- [ ] All automated PR checks pass +- [ ] Failed tests include local run results/screenshots proving they work +- [ ] Changes are documentation-only \ No newline at end of file diff --git a/.gitignore b/.gitignore index c6fd50da..2aeb3d4b 100644 --- a/.gitignore +++ b/.gitignore @@ -22,7 +22,11 @@ doc/_build/ /sagemaker-hyperpod/build /sagemaker-hyperpod/.coverage /sagemaker-hyperpod/.coverage.* + /hyperpod-cluster-stack-template/build +/hyperpod-pytorch-job-template/build +/hyperpod-custom-inference-template/build +/hyperpod-jumpstart-inference-template/build # Ignore all contents of result and results directories /result/ From 1d53a7d9c3cf48299364e8e43aded41c2399acf2 Mon Sep 17 00:00:00 2001 From: jzhaoqwa <52220743+zhaoqizqwang@users.noreply.github.com> Date: Tue, 9 Sep 2025 23:20:21 -0700 Subject: [PATCH 2/5] Update template --- .github/pull_request_template.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4cf7861a..5db031cb 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -20,8 +20,6 @@ ## Are integration tests added? ---- - ## Reviewer Guidelines ‼️ **Integration Test Policy**: PRs with failing integration tests cannot be merged without justification ‼️ **Merge Requirements** - One of the following must be true: From 59c5b95cc37273d33da066dae016be052eb17624 Mon Sep 17 00:00:00 2001 From: jzhaoqwa <52220743+zhaoqizqwang@users.noreply.github.com> Date: Tue, 9 Sep 2025 23:22:41 -0700 Subject: [PATCH 3/5] Update template format --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5db031cb..044b55b1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -21,8 +21,8 @@ ## Reviewer Guidelines -‼️ **Integration Test Policy**: PRs with failing integration tests cannot be merged without justification -‼️ **Merge Requirements** - One of the following must be true: + +‼️ **Merge Requirements**: PRs with failing integration tests cannot be merged without justification. One of the following must be true: - [ ] All automated PR checks pass - [ ] Failed tests include local run results/screenshots proving they work - [ ] Changes are documentation-only \ No newline at end of file From 63533964fbc6928614cc2b5167bee79d94e82509 Mon Sep 17 00:00:00 2001 From: jzhaoqwa <52220743+zhaoqizqwang@users.noreply.github.com> Date: Tue, 9 Sep 2025 23:23:09 -0700 Subject: [PATCH 4/5] Update format --- .github/pull_request_template.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 044b55b1..0d32b02d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -22,7 +22,9 @@ ## Reviewer Guidelines -‼️ **Merge Requirements**: PRs with failing integration tests cannot be merged without justification. One of the following must be true: +‼️ **Merge Requirements**: PRs with failing integration tests cannot be merged without justification. + +One of the following must be true: - [ ] All automated PR checks pass - [ ] Failed tests include local run results/screenshots proving they work - [ ] Changes are documentation-only \ No newline at end of file From 32a82673c3af295a49c29ae2ccb1f17c7be3ec6f Mon Sep 17 00:00:00 2001 From: jzhaoqwa <52220743+zhaoqizqwang@users.noreply.github.com> Date: Wed, 10 Sep 2025 00:12:47 -0700 Subject: [PATCH 5/5] Fix readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d2f8aaf5..1255c165 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,7 @@ hyp list-cluster |--------|------|-------------| | `--region ` | Optional | The region that the SageMaker HyperPod and EKS clusters are located. If not specified, it will be set to the region from the current AWS account credentials. | | `--namespace ` | Optional | The namespace that users want to check the quota with. Only the SageMaker managed namespaces are supported. | -| `--output ` | Optional | The output format. Available values are `table` and `json`. The default value is `json`. | +| `--output ` | Optional | The output format. Available values are `table` and `json`. The default value is `json`. | | `--debug` | Optional | Enable debug mode for detailed logging. | ### Connecting to a Cluster