fix(logger): exclude source_logger in copy_config_to_registered_loggers#1001
Merged
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
heitorlessa
approved these changes
Feb 4, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1001 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 119 119
Lines 5347 5347
Branches 610 610
========================================
Hits 5345 5345
Partials 2 2
Continue to review full report at Codecov.
|
Contributor
|
@houbie thank you so much for fixing it so quickly! <3 |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#999
Description of changes:
The source_logger was not added correctly to the exclusions.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.