fix(idempotency): idempotent_function should support standalone falsy values

[heitorlessa]

Issue number: #1663

Summary

When using idempotent_function for any synchronous Python function (different from Lambda Handler), customers set which keyword argument we should use to hash data as an idempotency key.

We raise RuntimeError for cases where the keyword argument wasn't used correctly to prevent hashing the incorrect data. For example, function was called without the keyword argument (function(), instead of function(data=data)).

However, the current logic incorrectly checks the value available in the keyword argument, rather than the keyword argument was used. The following code leads to a RuntimeError when we should be serializing None->null just fine.

...

import random

@idemp_f(data_keyword_argument="key")
def echo(key: str = None):
    return random.randint(1, 1000000)

echo(key=None)

Changes

Please provide a summary of what's being changed

This PR corrects the logic and only raises RuntimeError if the keyword argument specified for hashing isn't in the list of keyword arguments available at the function call.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[codecov-commenter]

Codecov Report

Base: 99.35% // Head: 99.35% // No change to project coverage 👍

Coverage data is based on head (f6da33f) compared to base (87de70c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1669   +/-   ##
========================================
  Coverage    99.35%   99.35%           
========================================
  Files          128      128           
  Lines         5908     5908           
  Branches       373      373           
========================================
  Hits          5870     5870           
  Misses          18       18           
  Partials        20       20           

Impacted Files	Coverage Δ
...da_powertools/utilities/idempotency/idempotency.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[leandrodamascena]

Nothing to change! LGTM!