feat(data_classes): Cognito custom auth triggers#178
Merged
Conversation
added 3 commits
September 24, 2020 13:30
Add support for "Custom Authentication Challenge Lambda Triggers": * Add response helpers * Implement "Define auth challenge", "Create auth challenge" and "Verify auth challenge response"
Codecov Report
@@ Coverage Diff @@
## develop #178 +/- ##
=========================================
Coverage 99.86% 99.86%
=========================================
Files 52 52
Lines 2154 2275 +121
Branches 97 99 +2
=========================================
+ Hits 2151 2272 +121
Misses 3 3
Continue to review full report at Codecov.
|
Nr18
reviewed
Sep 25, 2020
Contributor
|
dev builds fixed - please rebase and apologies for the inconvenience. https://github.com/awslabs/aws-lambda-powertools-python/runs/1165140290?check_suite_focus=true |
Co-authored-by: Joris Conijn <jco@woodwing.com>
heitorlessa
approved these changes
Oct 2, 2020
Contributor
heitorlessa
left a comment
heitorlessa
left a comment
There was a problem hiding this comment.
LGTM - Thanks a lot for those changes, and other minor fixes in docstrings I noticed @michaelbrewer
Merging it..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add support for "Custom Authentication Challenge Lambda Triggers":
auth challenge response"
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.