feat(data_classes): API Gateway V2 IAM and Lambda#201
Merged
heitorlessa merged 2 commits intoNov 3, 2020
Conversation
Update to support IAM and Lambda authorizer for API Gateway V2 trigger events
heitorlessa
suggested changes
Nov 2, 2020
Contributor
heitorlessa
left a comment
heitorlessa
left a comment
There was a problem hiding this comment.
LGTM except missing docstrings in certain properties for consistency
For , this refers to the context parameters returned by the lambda authorizer (optional) For , this refers to the IAM authorization details
Codecov Report
@@ Coverage Diff @@
## develop #201 +/- ##
========================================
Coverage 99.87% 99.87%
========================================
Files 67 67
Lines 2464 2499 +35
Branches 108 108
========================================
+ Hits 2461 2496 +35
Misses 3 3
Continue to review full report at Codecov.
|
Contributor
Author
|
@heitorlessa - made those changes. I did have to did around into the cognito docs for some of them and parts of the IAM / Lambda authorizers docs |
heitorlessa
approved these changes
Nov 3, 2020
Contributor
|
Looks great, thanks for those again @michaelbrewer !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update to support IAM and Lambda authorizer for API
Gateway V2 trigger events
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.