Favoured unique_ptr over shared_ptr for MediaPlayerRef. Added new OnReady signal to notify when the source is aware of its duration and frame dimensions. Modified sample to detect ImGui and disable debug UI if not available

Author: axjxwright

README.md

@@ -12,7 +12,8 @@ but the audio related functions did _not_ like being called from the main thread
 way to perform a lambda on the MTA thread which seems to make it happy. `RunSynchronousInMTAThread ( ... )`. 
 
 There's no documentation, please just have a look at the provided sample to see the basic usage. It's all fairly straight forward
-video-related stuff. You should be able to just check this out into your cinder install's block's folder and off you go.
+video-related stuff. You should be able to just check this out into your cinder install's block's folder and off you go. The sample
+is built against cinder 0.9.3 to utilise the built-in imgui debug UI, but should also work with 0.9.2 without the UI
 
 This was just a one night project for fun so it comes with absolutely no warranty. Hopefully it still comes in handy for someone :)
 

samples/SimplePlayback/src/SimplePlaybackApp.cxx

@@ -9,12 +9,17 @@
 #include "cinder/app/RendererGl.h"
 #include "cinder/app/App.h"
 #include "cinder/gl/gl.h"
-#include "cinder/CinderImGui.h"
 #include "AX-MediaPlayer.h"
 
+#if __has_include( "cinder/CinderImGui.h")
+    #include "cinder/CinderImGui.h"
+    //#define HAS_DEBUG_UI
+    namespace ui = ImGui;
+#endif
+
 using namespace ci;
 using namespace ci::app;
-namespace ui = ImGui;
+
 
 class SimplePlaybackApp : public app::App
 {
@@ -36,7 +41,9 @@ class SimplePlaybackApp : public app::App
 
 void SimplePlaybackApp::setup ( )
 {
+#ifdef HAS_DEBUG_UI
     ui::Initialize ( );
+#endif
 
     uint32_t flags = 0;
     if ( _hardwareAccelerated ) flags |= AX::Video::MediaPlayer::HardwareAccelerated;
@@ -45,6 +52,7 @@ void SimplePlaybackApp::setup ( )
     _player->OnSeekStart.connect ( [=] { std::cout << "OnSeekStart\n"; } );
     _player->OnSeekEnd.connect ( [=] { std::cout << "OnSeekEnd\n"; } );
     _player->OnComplete.connect ( [=] { std::cout << "OnComplete\n"; } );
+    _player->OnReady.connect ( [=] { std::cout << "OnReady: " << _player->GetDurationInSeconds ( ) << std::endl; } );
     _player->OnError.connect ( [=] ( AX::Video::MediaPlayer::Error error ) { _error = error; } );
     _player->Play ( );
 }
@@ -60,6 +68,7 @@ void SimplePlaybackApp::fileDrop ( FileDropEvent event )
     _player->OnSeekStart.connect ( [=] { std::cout << "OnSeekStart\n"; } );
     _player->OnSeekEnd.connect ( [=] { std::cout << "OnSeekEnd\n"; } );
     _player->OnComplete.connect ( [=] { std::cout << "OnComplete\n"; } );
+    _player->OnReady.connect ( [=] { std::cout << "OnReady: " << _player->GetDurationInSeconds ( ) << std::endl; } );
     _player->OnError.connect ( [=] ( AX::Video::MediaPlayer::Error error ) { _error = error; } );
     _player->Play ( );
 }
@@ -68,6 +77,7 @@ void SimplePlaybackApp::update ( )
 {
 }
 
+#ifdef HAS_DEBUG_UI
 struct ScopedWindow2
 {
     ScopedWindow2 ( const char * title, uint32_t flags )
@@ -80,11 +90,13 @@ struct ScopedWindow2
         ui::End ( );
     }
 };
+#endif
 
 void SimplePlaybackApp::draw ( )
 {
     gl::clear ( Colorf::black ( ) );
 
+#ifdef HAS_DEBUG_UI
     {
         ScopedWindow2 window{ "Settings", ImGuiWindowFlags_AlwaysAutoResize };
 
@@ -151,6 +163,7 @@ void SimplePlaybackApp::draw ( )
             }
         }
     }
+#endif
 
     if ( _player->CheckNewFrame ( ) )
     {

src/AX-MediaPlayer.cxx

@@ -160,6 +160,11 @@ namespace AX
             return _impl->IsSeeking ( );
         }
 
+        bool MediaPlayer::IsReady ( ) const
+        {
+            return _impl->IsReady ( );
+        }
+
         bool MediaPlayer::HasAudio ( ) const
         {
             return _impl->HasAudio ( );

src/AX-MediaPlayer.h

@@ -18,7 +18,7 @@
 
 namespace AX::Video
 {
-    using MediaPlayerRef = std::shared_ptr<class MediaPlayer>;
+    using MediaPlayerRef = std::unique_ptr<class MediaPlayer>;
     class MediaPlayer : public ci::Noncopyable
     {
     public:
@@ -88,10 +88,11 @@ namespace AX::Video
         bool    IsPlaying ( ) const;
         bool    IsPaused ( ) const;
         bool    IsSeeking ( ) const;
+        bool    IsReady ( ) const;
 
         bool    HasAudio ( ) const;
         bool    HasVideo ( ) const;
-
+        
         void    SeekToSeconds ( float seconds, bool approximate = false );
         void    SeekToPercentage ( float normalizedTime, bool approximate = false );
 
@@ -103,6 +104,7 @@ namespace AX::Video
         const ci::Surface8uRef & GetSurface ( ) const;
         FrameLeaseRef GetTexture ( ) const;
 
+        EventSignal OnReady;
         EventSignal OnComplete;
         EventSignal OnPlay;
         EventSignal OnPause;

src/Win32/AX-MediaPlayerWin32Impl.cxx

@@ -349,7 +349,9 @@ namespace AX::Video
                     _size = ivec2 ( w, h );
                     _duration = static_cast<float> ( _mediaEngine->GetDuration ( ) );
                     _renderPath->InitializeRenderTarget ( _size );
-                
+                    _hasMetadata = true;
+                    _owner.OnReady.emit ( );
+
                     break;
                 }
 
@@ -606,6 +608,11 @@ namespace AX::Video
         return false;
     }
 
+    bool MediaPlayer::Impl::IsReady ( ) const
+    {
+        return _hasMetadata;
+    }
+
     bool MediaPlayer::Impl::HasAudio ( ) const
     {
         if ( _mediaEngine )

src/Win32/AX-MediaPlayerWin32Impl.h

@@ -81,6 +81,7 @@ namespace AX::Video
         bool    IsPlaying ( ) const;
         bool    IsPaused ( ) const;
         bool    IsSeeking ( ) const;
+        bool    IsReady ( ) const;
 
         bool    HasAudio ( ) const;
         bool    HasVideo ( ) const;
@@ -129,6 +130,7 @@ namespace AX::Video
         ci::ivec2                   _size;
         uint32_t                    _flags{ 0 };
         float                       _duration{ 0.0f };
+        bool                        _hasMetadata{ false };
         ci::Surface8uRef            _surface{ nullptr };
         RenderPathRef               _renderPath;
         ComPtr<IMFMediaEngine>      _mediaEngine{ nullptr };