Skip to content

Commit e757412

Browse files
committed
fix: remarks
Signed-off-by: Bence Csati <bcsati@cisco.com>
1 parent 9cef44a commit e757412

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

examples/try-locally.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ spec:
8686
labels:
8787
app.kubernetes.io/name: reloader-test-deployment-to-be-reloaded
8888
annotations:
89+
secrets-webhook.security.bank-vaults.io/provider: "vault"
8990
secrets-webhook.security.bank-vaults.io/vault-addr: "https://vault:8200"
9091
secrets-webhook.security.bank-vaults.io/vault-tls-secret: vault-tls
9192
secrets-reloader.security.bank-vaults.io/reload-on-secret-change: "true"

pkg/reloader/reloader_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ import (
2424

2525
func TestIncrementReloadCountAnnotation(t *testing.T) {
2626
tests := []struct {
27-
name string
28-
annotations map[string]string
29-
expectedAnnoation map[string]string
27+
name string
28+
annotations map[string]string
29+
expectedAnnotations map[string]string
3030
}{
3131
{
3232
name: "no annotation should add annotation",
3333
annotations: map[string]string{},
34-
expectedAnnoation: map[string]string{
34+
expectedAnnotations: map[string]string{
3535
ReloadCountAnnotationName: "1",
3636
},
3737
},
@@ -40,7 +40,7 @@ func TestIncrementReloadCountAnnotation(t *testing.T) {
4040
annotations: map[string]string{
4141
ReloadCountAnnotationName: "1",
4242
},
43-
expectedAnnoation: map[string]string{
43+
expectedAnnotations: map[string]string{
4444
ReloadCountAnnotationName: "2",
4545
},
4646
},
@@ -58,7 +58,7 @@ func TestIncrementReloadCountAnnotation(t *testing.T) {
5858

5959
incrementReloadCountAnnotation(podTemplateSpec)
6060

61-
assert.Equal(t, ttp.expectedAnnoation, podTemplateSpec.Annotations)
61+
assert.Equal(t, ttp.expectedAnnotations, podTemplateSpec.Annotations)
6262
})
6363
}
6464
}

0 commit comments

Comments
 (0)