Merged
Conversation
added 6 commits
March 7, 2013 14:19
Fixed:
pokemon_pb.erl:52: The pattern <Default, _> can never match since previous clauses completely covered the type <_,'none'>
pokemon_pb.erl:53: The pattern <Val, _> can never match since previous clauses completely covered the type <_,'none'>
protobuffs.erl:373: Invalid type specification for function protobuffs:encode_field_tag/2. The success typing is (non_neg_integer(),0 | 1 | 2 | 5) -> [integer(),...]
protobuffs.erl:387: Invalid type specification for function protobuffs:encode_varint/1. The success typing is (integer()) -> [integer(),...]
protobuffs.erl:393: Invalid type specification for function protobuffs:encode_varint/2. The success typing is (integer(),[integer()]) -> [integer(),...]
Safe to ignore:
pokemon_pb.erl:46: The variable _ can never match since previous clauses completely covered the type #pikachu{}
ghost
assigned
Contributor
|
Ran dialyzer on this (there are still warnings) and master (there are many more warnings). All the changes make sense and things work as expected. +1 from me |
|
I just installed riak-erlang-client (latest tag 1.3.1.1) and got a terminal screen sprayed full of warnings from (I assume) this :) Looking at the tags, the last release was 2 months ago. Is there any plan to release an update? |
Author
|
@d11wtq Yes, there will be an update soon, probably around the time of the 1.4 release. |
|
Awesome, thanks. |
russelldb
pushed a commit
that referenced
this pull request
Apr 23, 2018
Remove need to have protoc available in Python source package. Closes #36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warn_missing_specflag is obnoxious, and overkill when we properly dialyze. Removed.