Merged
Conversation
added 6 commits
June 5, 2013 10:48
…ode. Lots of changes to version_set.cc to make 2i not hit leveldb stall. Not completely happy with tuning of version_set.cc ... but it does survive tests now (at least on FusionIO).
…special case of first sorted level.
ghost
assigned
…mpaction ... now it is. This is to reduce disk corruption creating weird, random segfaults (and causing tech support calls).
db/version_set.cc
Outdated
There was a problem hiding this comment.
Any reason not to just delete this code rather than leave it commented out? If there's a reason to keep it around, maybe the comment should make note of that.
Contributor
Author
There was a problem hiding this comment.
Laziness. Will remove before push to master.
|
After reviewing and testing the code in the small (on my laptop) and then discussing with MvM these new heuristics for compaction and which levels may contain overlapping sst files I feel that these changes will improve things as anticipated and I don't see any obvious drawbacks. +1 to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/basho/leveldb/wiki/Mv-bloom-size-limit