Create .pid files for package builds#49
Merged
jaredmorrow merged 5 commits intomasterfrom May 2, 2013
Merged
Conversation
jaredmorrow
added a commit
that referenced
this pull request
May 2, 2013
Contributor
Author
|
Here's a sample run of the latest code |
Contributor
|
+1 on visual and conceptual review. I didn't actually test it because testing branches of node_package sucks. |
jaredmorrow
added a commit
that referenced
this pull request
May 2, 2013
Create .pid files for package builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To properly support OS startup / shutdown scripts (sysvinit for example) we would like to enable the creation/deletion of .pid files. The issue with .pid creation in the init files (as is standard) is the system can get into a bad state if for example init is used for runner startup, but then ./runner stop is used for shutdown.
This PR attempts to address that by creating the .pid files in the runner script itself. No attempt was made to make this setup work for devrel (multi-node, single machine) builds because those are typically run as non-root.