provide a Location header for the same api version on POST#487
Merged
provide a Location header for the same api version on POST#487
Conversation
If a POST comes in to /buckets/B/keys, the Location header generated should be of the form /buckets/B/keys/K. If the post arrived at /riak/B, the Location should be /riak/B/K.
ghost
assigned
Contributor
|
WFM, and test is good +1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a POST comes in to /buckets/B/keys, the Location header generated
should be of the form /buckets/B/keys/K. If the post arrived at /riak/B,
the Location should be /riak/B/K.
This PR addresses @seancribbs concern in #432.
A test for this behavior is provided in basho/riak_test#205.