Changes needed to expose FSM timeouts to clients#521
Merged
Conversation
- change delete in riak_client to honor timeouts passed
in Options
- change the various object interfaces to collect and
pass on the timeout values
Contributor
Author
|
associated riak test: basho/riak_test#243 |
ghost
assigned
src/riak_client.erl
Outdated
Contributor
There was a problem hiding this comment.
This should be at debug level and probably have a more useful message.
src/riak_kv_wm_object.erl
Outdated
Contributor
There was a problem hiding this comment.
If you provide a bad timeout value, it doesn't actually use the default but returns a 400 response.
Contributor
|
I also wonder about the arbitrary 100ms being added to the timeout, which produces some strange results if you set the timeout very low. In a sense, you cannot set a timeout lower than 100ms. |
Contributor
|
👍 to merge. |
evanmcc
added a commit
that referenced
this pull request
Apr 3, 2013
Changes needed to expose FSM timeouts to clients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in Options
pass on the timeout values
requires basho/riak_pb#38