Remove need to have protoc available in Python source package. Closes #36#42
Merged
seancribbs merged 2 commits intomasterfrom May 1, 2013
Merged
Remove need to have protoc available in Python source package. Closes #36#42seancribbs merged 2 commits intomasterfrom
seancribbs merged 2 commits intomasterfrom
Conversation
ghost
assigned
Contributor
|
To be able to run the python_compile and python_clean make targets, I had to tweak setup.py and remove this line: I'm unable to run plain make due to Maven not liking me, but that's another story :( |
Contributor
|
Ok, I can now run make python_compile and make python_clean from a pristine virtual environment with protoc installed system-wide (failing if not global protoc is there). I'd say: 👍 💃 ⛵ |
seancribbs
pushed a commit
that referenced
this pull request
May 1, 2013
Remove need to have protoc available in Python source package. Closes #36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #37