Merge pull request mozilla-b2g#11219 from gasolin/issue-887670vs

Bug 887670 - [Test][System] Unit test for ValueSelector, r=rudy

Author: gasolin

apps/system/js/value_selector/value_selector.js

@@ -27,14 +27,13 @@ var ValueSelector = {
       var typeToHandle = ['select-one', 'select-multiple', 'date',
         'time', 'datetime', 'datetime-local', 'blur'];
 
-      var type = evt.detail.type;
+      var currentInputType = evt.detail.type;
       // handle the <select> element and inputs with type of date/time
       // in system app for now
-      if (typeToHandle.indexOf(type) == -1)
+      if (typeToHandle.indexOf(currentInputType) == -1)
         return;
 
       var currentValue = evt.detail.value;
-      var currentInputType = evt.detail.type;
       self._currentDatetimeValue = currentValue;
       self._currentInputType = currentInputType;
 

apps/system/test/unit/value_selector_test.js

@@ -0,0 +1,65 @@
+'use strict';
+
+mocha.globals(['ValueSelector']);
+
+requireApp('system/js/value_selector/value_selector.js');
+requireApp('system/test/unit/mock_settings_listener.js');
+requireApp('system/test/unit/mock_l10n.js');
+
+suite('value selector/value selector', function() {
+  var element;
+
+  var realL10n;
+  var realKeyboard;
+  var realSettings;
+  var stubById;
+
+  suiteSetup(function() {
+    realSettings = navigator.mozSettings;
+    navigator.mozSettings = MockNavigatorSettings;
+
+    realL10n = navigator.mozL10n;
+    navigator.mozL10n = MockL10n;
+
+    realKeyboard = window.navigator.mozKeyboard;
+    window.navigator.mozKeyboard = sinon.stub();
+  });
+
+  suiteTeardown(function() {
+    navigator.mozSettings = realSettings;
+    navigator.mozL10n = realL10n;
+    window.navigator.mozKeyboard = realKeyboard;
+  });
+
+  teardown(function() {
+    stubById.restore();
+  });
+
+  setup(function() {
+    // mockup element
+    function mock_obj() {
+      this.querySelector = function() {
+        return document.createElement('div');
+      };
+      this.addEventListener = function() {
+        return document.createElement('div');
+      };
+    };
+
+    stubById = this.sinon.stub(document, 'getElementById')
+                   .returns(new mock_obj());
+
+    ValueSelector.init();
+    element = document.getElementById('value-selector');
+  });
+
+  test('show', function() {
+    ValueSelector.show();
+    assert.isFalse(element.hidden);
+  });
+
+  test('hide', function() {
+    ValueSelector.hide();
+    assert.isTrue(element.hidden);
+  });
+});