fix lpm to return non-zero exit code if package installation fails (localstack#5038)

Author: alexrashed

localstack/cli/lpm.py

@@ -41,14 +41,15 @@ def _do_install(pkg):
         console.print(f"[green]installed[/green] [bold]{pkg}[/bold]")
     except Exception as e:
         console.print(f"[red]error[/red] installing {pkg}: {e}")
+        raise e
 
 
 @cli.command()
 @click.argument("package", nargs=-1, required=True)
 @click.option(
     "--parallel",
     type=int,
-    default=0,
+    default=1,
     required=False,
     help="how many installers to run in parallel processes",
 )
@@ -63,21 +64,15 @@ def install(package, parallel):
         if pkg not in installers:
             raise ClickException(f"unable to locate installer for package {pkg}")
 
-    if not parallel:
-        # install one by one
-        for pkg in package:
-            console.print(f"installing [bold]{pkg}[/bold]")
-            with console.status("installing..."):
-                try:
-                    installers[pkg]()
-                except Exception as e:
-                    console.print(f"[red]error[/red]: {e}")
-    else:
+    if parallel > 1:
         console.print(f"install {parallel} packages in parallel:")
-        # collect installers and install in parallel:
 
+    # collect installers and install in parallel:
+    try:
         with Pool(processes=parallel) as pool:
             pool.map(_do_install, package)
+    except Exception:
+        raise ClickException("one or more package installations failed.")
 
 
 @cli.command(name="list")

tests/unit/cli/test_lpm.py

@@ -1,9 +1,11 @@
 import os.path
+from typing import List
 
 import pytest
 from click.testing import CliRunner
 
 from localstack.cli.lpm import cli, console
+from localstack.services.install import CommunityInstallerRepository, Installer
 
 
 @pytest.fixture
@@ -22,7 +24,27 @@ def test_list(runner, monkeypatch):
 def test_install_with_non_existing_package_fails(runner):
     result = runner.invoke(cli, ["install", "elasticmq", "funny"])
     assert result.exit_code == 1
-    assert "unable to locate installer for package funny"
+    assert "unable to locate installer for package funny" in result.output
+
+
+def test_install_failure_returns_non_zero_exit_code(runner, monkeypatch):
+    def failing_installer():
+        raise Exception("failing installer")
+
+    def successful_installer():
+        pass
+
+    def patched_get_installer(self) -> List[Installer]:
+        return [
+            ("failing-installer", failing_installer),
+            ("successful-installer", successful_installer),
+        ]
+
+    monkeypatch.setattr(CommunityInstallerRepository, "get_installer", patched_get_installer)
+
+    result = runner.invoke(cli, ["install", "successful-installer", "failing-installer"])
+    assert result.exit_code == 1
+    assert "one or more package installations failed." in result.output
 
 
 def test_install_with_package(runner):