Skip to content

Commit 8cf676e

Browse files
authored
perf: Remove no-sandbox from copy exec requirements (#1220)
Path mapping does not work without sandboxing, and deduping the actions (especially npm packages/etc) is likely a nicer win than the benefit of not sandboxing, given the lower number of inputs.
1 parent 34b7564 commit 8cf676e

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

lib/private/copy_common.bzl

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,5 @@
11
"Helpers for copy rules"
22

3-
# Hints for Bazel spawn strategy
43
COPY_EXECUTION_REQUIREMENTS = {
5-
# ----------------+-----------------------------------------------------------------------------
6-
# no-sandbox | Results in the action or test never being sandboxed; it can still be cached
7-
# | or run remotely.
8-
# ----------------+-----------------------------------------------------------------------------
9-
# See https://bazel.google.cn/reference/be/common-definitions?hl=en&authuser=0#common-attributes
10-
#
11-
# Sandboxing for this action is wasteful since there is a 1:1 mapping of input file/directory to
12-
# output file/directory so little room for non-hermetic inputs to sneak in to the execution.
13-
"no-sandbox": "1",
144
"supports-path-mapping": "1",
155
}

0 commit comments

Comments
 (0)