From 3999c959e869e9b7c1f93e0ebfe33b932f7897d5 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Wed, 11 May 2022 11:41:45 -0700 Subject: [PATCH] fix(docs): stray text in npm_install docs "symlink_node_modules is True" doesn't make any sense in this position. I think it was a stray copy and paste from the beginning of the paragraph. --- docs/Built-ins.md | 6 ++---- internal/npm_install/npm_install.bzl | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/docs/Built-ins.md b/docs/Built-ins.md index 8647ddb6fd..5d8a6b3480 100755 --- a/docs/Built-ins.md +++ b/docs/Built-ins.md @@ -549,8 +549,7 @@ Defaults to `[]` If symlink_node_modules is True, this attribute is optional since the package manager will run in your workspace folder. It is recommended, however, that all files that the package manager depends on, such as `.rc` files or files used in `postinstall`, are added -symlink_node_modules is True so that the repository rule is rerun when any of these files -change. +so that the repository rule is rerun when any of these files change. If symlink_node_modules is False, the package manager is run in the bazel external repository so all files that the package manager depends on must be listed. @@ -1214,8 +1213,7 @@ Defaults to `[]` If symlink_node_modules is True, this attribute is optional since the package manager will run in your workspace folder. It is recommended, however, that all files that the package manager depends on, such as `.rc` files or files used in `postinstall`, are added -symlink_node_modules is True so that the repository rule is rerun when any of these files -change. +so that the repository rule is rerun when any of these files change. If symlink_node_modules is False, the package manager is run in the bazel external repository so all files that the package manager depends on must be listed. diff --git a/internal/npm_install/npm_install.bzl b/internal/npm_install/npm_install.bzl index d7804b7e10..23a40385c2 100644 --- a/internal/npm_install/npm_install.bzl +++ b/internal/npm_install/npm_install.bzl @@ -34,8 +34,7 @@ COMMON_ATTRIBUTES = dict(dict(), **{ If symlink_node_modules is True, this attribute is optional since the package manager will run in your workspace folder. It is recommended, however, that all files that the package manager depends on, such as `.rc` files or files used in `postinstall`, are added -symlink_node_modules is True so that the repository rule is rerun when any of these files -change. +so that the repository rule is rerun when any of these files change. If symlink_node_modules is False, the package manager is run in the bazel external repository so all files that the package manager depends on must be listed.