From 8ba7bf4514de74af7403e83c1acca2d14b4fa733 Mon Sep 17 00:00:00 2001 From: Aaron Brager Date: Sat, 29 Sep 2018 18:30:38 -0700 Subject: [PATCH 1/9] Update to Swift 4.2 --- Example-iOS/AppDelegate.swift | 2 +- Gemfile.lock | 2 +- .../project.pbxproj | 24 +++++++------------ Source/Model/Section.swift | 2 +- Source/Model/Subtitle.swift | 4 ++-- Source/Protocol/RowStyle.swift | 4 ++-- Source/QuickTableViewController.swift | 4 ++-- Source/Rows/NavigationRow.swift | 4 ++-- Source/Rows/OptionRow.swift | 4 ++-- Source/Rows/SwitchRow.swift | 4 ++-- Source/Rows/TapActionRow.swift | 4 ++-- Source/Views/SwitchCell.swift | 2 +- Source/Views/TapActionCell.swift | 2 +- 13 files changed, 28 insertions(+), 34 deletions(-) diff --git a/Example-iOS/AppDelegate.swift b/Example-iOS/AppDelegate.swift index f3b02381..c780991a 100644 --- a/Example-iOS/AppDelegate.swift +++ b/Example-iOS/AppDelegate.swift @@ -31,7 +31,7 @@ internal final class AppDelegate: UIResponder, UIApplicationDelegate { var window: UIWindow? - func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]? = nil) -> Bool { + func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool { if #available(iOS 9.0, *) { // See AppearanceViewController for the setups. diff --git a/Gemfile.lock b/Gemfile.lock index 488d0253..183884fd 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -105,7 +105,7 @@ GEM ffi (>= 0.5.0, < 2) redcarpet (3.4.0) rouge (2.0.7) - ruby-macho (1.2.0) + ruby-macho (1.3.0) sass (3.5.7) sass-listen (~> 4.0.0) sass-listen (4.0.0) diff --git a/QuickTableViewController.xcodeproj/project.pbxproj b/QuickTableViewController.xcodeproj/project.pbxproj index 672fede2..ab6a1097 100644 --- a/QuickTableViewController.xcodeproj/project.pbxproj +++ b/QuickTableViewController.xcodeproj/project.pbxproj @@ -703,18 +703,18 @@ TargetAttributes = { B51F21A11F417037009BC2C9 = { CreatedOnToolsVersion = 8.3.3; - LastSwiftMigration = 0900; + LastSwiftMigration = 1000; ProvisioningStyle = Manual; }; B51F21BF1F41E600009BC2C9 = { CreatedOnToolsVersion = 8.3.3; - LastSwiftMigration = 0900; + LastSwiftMigration = 1000; ProvisioningStyle = Manual; TestTargetID = B51F21A11F417037009BC2C9; }; B5334F121B8CC5BD00C64A6D = { CreatedOnToolsVersion = 6.4; - LastSwiftMigration = 0900; + LastSwiftMigration = 1000; }; B5334F1D1B8CC5BD00C64A6D = { CreatedOnToolsVersion = 6.4; @@ -1160,8 +1160,7 @@ PRODUCT_NAME = "$(TARGET_NAME)"; PROVISIONING_PROFILE_SPECIFIER = ""; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; - SWIFT_SWIFT3_OBJC_INFERENCE = Default; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; }; name = Debug; }; @@ -1182,8 +1181,7 @@ PRODUCT_NAME = "$(TARGET_NAME)"; PROVISIONING_PROFILE_SPECIFIER = ""; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; - SWIFT_SWIFT3_OBJC_INFERENCE = Default; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; }; name = Release; }; @@ -1206,8 +1204,7 @@ PROVISIONING_PROFILE = ""; PROVISIONING_PROFILE_SPECIFIER = ""; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; - SWIFT_SWIFT3_OBJC_INFERENCE = Default; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; TEST_TARGET_NAME = "Example-iOS"; }; name = Debug; @@ -1230,8 +1227,7 @@ PROVISIONING_PROFILE = ""; PROVISIONING_PROFILE_SPECIFIER = ""; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; - SWIFT_SWIFT3_OBJC_INFERENCE = Default; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; TEST_TARGET_NAME = "Example-iOS"; }; name = Release; @@ -1375,8 +1371,7 @@ PRODUCT_NAME = QuickTableViewController; SKIP_INSTALL = YES; SWIFT_OPTIMIZATION_LEVEL = "-Onone"; - SWIFT_SWIFT3_OBJC_INFERENCE = Default; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; }; name = Debug; }; @@ -1397,8 +1392,7 @@ PRODUCT_NAME = QuickTableViewController; SKIP_INSTALL = YES; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; - SWIFT_SWIFT3_OBJC_INFERENCE = Default; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; }; name = Release; }; diff --git a/Source/Model/Section.swift b/Source/Model/Section.swift index 543fc874..4a40f252 100644 --- a/Source/Model/Section.swift +++ b/Source/Model/Section.swift @@ -41,7 +41,7 @@ open class Section { // MARK: - Properties /// The text of the section title. - open let title: String? + public let title: String? /// The array of rows in the section. open var rows: [Row & RowStyle] diff --git a/Source/Model/Subtitle.swift b/Source/Model/Subtitle.swift index 286f51fb..5a3cb5eb 100644 --- a/Source/Model/Subtitle.swift +++ b/Source/Model/Subtitle.swift @@ -39,7 +39,7 @@ public enum Subtitle: Equatable { case leftAligned(String) /// Returns the corresponding table view cell style. - public var style: UITableViewCellStyle { + public var style: UITableViewCell.CellStyle { switch self { case .none: return .default case .belowTitle: return .subtitle @@ -79,7 +79,7 @@ public enum Subtitle: Equatable { } -internal extension UITableViewCellStyle { +internal extension UITableViewCell.CellStyle { var stringValue: String { switch self { diff --git a/Source/Protocol/RowStyle.swift b/Source/Protocol/RowStyle.swift index 427b8cb9..5d8ee262 100644 --- a/Source/Protocol/RowStyle.swift +++ b/Source/Protocol/RowStyle.swift @@ -36,13 +36,13 @@ public protocol RowStyle { var cellReuseIdentifier: String { get } /// The style of the table view cell to display the row. - var cellStyle: UITableViewCellStyle { get } + var cellStyle: UITableViewCell.CellStyle { get } /// The icon of the row. var icon: Icon? { get } /// The type of standard accessory view the cell should use. - var accessoryType: UITableViewCellAccessoryType { get } + var accessoryType: UITableViewCell.AccessoryType { get } /// The flag that indicates whether the table view cell should trigger the action when selected. var isSelectable: Bool { get } diff --git a/Source/QuickTableViewController.swift b/Source/QuickTableViewController.swift index 6f43e473..e413d76e 100644 --- a/Source/QuickTableViewController.swift +++ b/Source/QuickTableViewController.swift @@ -51,7 +51,7 @@ open class QuickTableViewController: UIViewController, UITableViewDataSource, UI - returns: An initialized `QuickTableViewController` object. */ - public convenience init(style: UITableViewStyle) { + public convenience init(style: UITableView.Style) { self.init(nibName: nil, bundle: nil) tableView = UITableView(frame: .zero, style: style) } @@ -68,7 +68,7 @@ open class QuickTableViewController: UIViewController, UITableViewDataSource, UI view.addSubview(tableView) tableView.frame = view.bounds tableView.autoresizingMask = [.flexibleWidth, .flexibleHeight] - tableView.rowHeight = UITableViewAutomaticDimension + tableView.rowHeight = UITableView.automaticDimension tableView.estimatedRowHeight = 44 tableView.dataSource = self tableView.delegate = self diff --git a/Source/Rows/NavigationRow.swift b/Source/Rows/NavigationRow.swift index 5b1195d7..03a73c77 100644 --- a/Source/Rows/NavigationRow.swift +++ b/Source/Rows/NavigationRow.swift @@ -69,7 +69,7 @@ open class NavigationRow: NavigationRowCompatible, Equatable } /// Returns the table view cell style for the specified subtitle. - public var cellStyle: UITableViewCellStyle { + public var cellStyle: UITableViewCell.CellStyle { return subtitle?.style ?? .default } @@ -77,7 +77,7 @@ open class NavigationRow: NavigationRowCompatible, Equatable public let icon: Icon? /// Returns `.disclosureIndicator` when action is not nil, otherwise returns `.none`. - public var accessoryType: UITableViewCellAccessoryType { + public var accessoryType: UITableViewCell.AccessoryType { return (action == nil) ? .none : .disclosureIndicator } diff --git a/Source/Rows/OptionRow.swift b/Source/Rows/OptionRow.swift index dbb0572d..222c4a2e 100644 --- a/Source/Rows/OptionRow.swift +++ b/Source/Rows/OptionRow.swift @@ -81,13 +81,13 @@ open class OptionRow: OptionRowCompatible, Equatable { public let cellReuseIdentifier: String = T.reuseIdentifier /// The cell style is `.default`. - public let cellStyle: UITableViewCellStyle = .default + public let cellStyle: UITableViewCell.CellStyle = .default /// The icon of the row. public let icon: Icon? /// Returns `.checkmark` when the row is selected, otherwise returns `.none`. - public var accessoryType: UITableViewCellAccessoryType { + public var accessoryType: UITableViewCell.AccessoryType { return isSelected ? .checkmark : .none } diff --git a/Source/Rows/SwitchRow.swift b/Source/Rows/SwitchRow.swift index fc8e3bc9..55bfef96 100644 --- a/Source/Rows/SwitchRow.swift +++ b/Source/Rows/SwitchRow.swift @@ -81,7 +81,7 @@ open class SwitchRow: SwitchRowCompatible, Equatable { public let cellReuseIdentifier: String = T.reuseIdentifier /// The cell style is `.default`. - public let cellStyle: UITableViewCellStyle = .default + public let cellStyle: UITableViewCell.CellStyle = .default /// The icon of the row. public let icon: Icon? @@ -89,7 +89,7 @@ open class SwitchRow: SwitchRowCompatible, Equatable { #if os(iOS) /// The default accessory type is `.none`. - public let accessoryType: UITableViewCellAccessoryType = .none + public let accessoryType: UITableViewCell.AccessoryType = .none /// The `SwitchRow` should not be selectable. public let isSelectable: Bool = false diff --git a/Source/Rows/TapActionRow.swift b/Source/Rows/TapActionRow.swift index e8aaaf01..7b8d5e41 100644 --- a/Source/Rows/TapActionRow.swift +++ b/Source/Rows/TapActionRow.swift @@ -63,13 +63,13 @@ open class TapActionRow: TapActionRowCompatible, Equatable { public let cellReuseIdentifier: String = T.reuseIdentifier /// The cell style is `.default`. - public let cellStyle: UITableViewCellStyle = .default + public let cellStyle: UITableViewCell.CellStyle = .default /// The default icon is nil. public let icon: Icon? = nil /// The default accessory type is `.none`. - public let accessoryType: UITableViewCellAccessoryType = .none + public let accessoryType: UITableViewCell.AccessoryType = .none /// The `TapActionRow` is selectable when action is not nil. public var isSelectable: Bool { diff --git a/Source/Views/SwitchCell.swift b/Source/Views/SwitchCell.swift index fa809145..f85bb06a 100644 --- a/Source/Views/SwitchCell.swift +++ b/Source/Views/SwitchCell.swift @@ -63,7 +63,7 @@ open class SwitchCell: UITableViewCell, Configurable { - returns: An initialized `SwitchCell` object. */ - public override init(style: UITableViewCellStyle, reuseIdentifier: String?) { + public override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) { super.init(style: style, reuseIdentifier: reuseIdentifier) setUpAppearance() } diff --git a/Source/Views/TapActionCell.swift b/Source/Views/TapActionCell.swift index 972f4b8b..88f01ee2 100644 --- a/Source/Views/TapActionCell.swift +++ b/Source/Views/TapActionCell.swift @@ -42,7 +42,7 @@ open class TapActionCell: UITableViewCell { - returns: An initialized `TapActionCell` object. */ - public override init(style: UITableViewCellStyle, reuseIdentifier: String?) { + public override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) { super.init(style: .default, reuseIdentifier: reuseIdentifier) setUpAppearance() } From 92e6a069465758627247fac35e093d4f57a53444 Mon Sep 17 00:00:00 2001 From: Aaron Brager Date: Sat, 6 Oct 2018 09:08:47 +0800 Subject: [PATCH 2/9] Update Travis osx_image and Podspec swift_version --- .travis.yml | 2 +- QuickTableViewController.podspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index e1cfedc3..eacc8a4d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,5 +1,5 @@ language: objective-c -osx_image: xcode9.3beta +osx_image: xcode10 matrix: include: - env: VERSION=latest diff --git a/QuickTableViewController.podspec b/QuickTableViewController.podspec index e8cc8628..48f13465 100644 --- a/QuickTableViewController.podspec +++ b/QuickTableViewController.podspec @@ -8,7 +8,7 @@ Pod::Spec.new do |s| s.license = { type: "MIT", file: "LICENSE" } s.author = "bcylin" - s.swift_version = "4.0" + s.swift_version = "4.2" s.ios.deployment_target = "8.0" s.tvos.deployment_target = "9.0" From 06997a19444e77e40f1744123b3358a29a14acc3 Mon Sep 17 00:00:00 2001 From: Aaron Brager Date: Sat, 6 Oct 2018 09:10:39 +0800 Subject: [PATCH 3/9] Add Swiftlint fix --- Example-iOS/AppDelegate.swift | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Example-iOS/AppDelegate.swift b/Example-iOS/AppDelegate.swift index c780991a..782d60e6 100644 --- a/Example-iOS/AppDelegate.swift +++ b/Example-iOS/AppDelegate.swift @@ -31,7 +31,9 @@ internal final class AppDelegate: UIResponder, UIApplicationDelegate { var window: UIWindow? + // swiftlint:disable line_length func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool { + // swiftlint:enable line_length if #available(iOS 9.0, *) { // See AppearanceViewController for the setups. From 907e2224c879a7ac002043c1f36ac3820275603a Mon Sep 17 00:00:00 2001 From: Aaron Brager Date: Sat, 6 Oct 2018 09:23:00 +0800 Subject: [PATCH 4/9] Open simulator with -a instead of -b --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index eacc8a4d..e731bc6d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,7 +9,7 @@ cache: before_install: - export LANG=en_US.UTF-8 - xcrun instruments -s devices - - open -b com.apple.iphonesimulator + - open -a /Applications/Xcode.app/Contents/Developer/Applications/Simulator.app install: - bundle install --without development --deployment --jobs=3 --retry=3 - bundle exec pod install From e954f5f53b8f1acbae2b5f11110153611caaa233 Mon Sep 17 00:00:00 2001 From: Aaron Brager Date: Sat, 6 Oct 2018 09:28:32 +0800 Subject: [PATCH 5/9] Update SWIFT_VERSION in build script --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index e731bc6d..6d1e0e0e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,7 +17,7 @@ before_script: - if [ -n "$DANGER_GITHUB_API_TOKEN" ]; then bundle exec danger; fi script: - set -o pipefail - - xcodebuild clean build -workspace QuickTableViewController.xcworkspace -scheme QuickTableViewController-iOS -sdk iphonesimulator SWIFT_VERSION=3.0 | bundle exec xcpretty -c + - xcodebuild clean build -workspace QuickTableViewController.xcworkspace -scheme QuickTableViewController-iOS -sdk iphonesimulator SWIFT_VERSION=4.2 | bundle exec xcpretty -c - bundle exec rake "test:ios[QuickTableViewController-iOS]" - bundle exec rake "test:tvos[QuickTableViewController-tvOS]" - bash <(curl -s https://codecov.io/bash) -cF ios -J "QuickTableViewController" From 426e3523ce1c585a94df54539108fbbf588885e5 Mon Sep 17 00:00:00 2001 From: Aaron Brager Date: Sat, 6 Oct 2018 09:42:28 +0800 Subject: [PATCH 6/9] tvOS update --- Example-iOS/AppDelegate.swift | 2 -- Example-tvOS/AppDelegate.swift | 2 +- QuickTableViewController.xcodeproj/project.pbxproj | 10 ++++++---- Source/Rows/SwitchRow.swift | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Example-iOS/AppDelegate.swift b/Example-iOS/AppDelegate.swift index 782d60e6..c780991a 100644 --- a/Example-iOS/AppDelegate.swift +++ b/Example-iOS/AppDelegate.swift @@ -31,9 +31,7 @@ internal final class AppDelegate: UIResponder, UIApplicationDelegate { var window: UIWindow? - // swiftlint:disable line_length func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool { - // swiftlint:enable line_length if #available(iOS 9.0, *) { // See AppearanceViewController for the setups. diff --git a/Example-tvOS/AppDelegate.swift b/Example-tvOS/AppDelegate.swift index 9b0f0ef9..57dbadf6 100644 --- a/Example-tvOS/AppDelegate.swift +++ b/Example-tvOS/AppDelegate.swift @@ -31,7 +31,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate { var window: UIWindow? - func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool { + func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { window = UIWindow(frame: UIScreen.main.bounds) window?.rootViewController = UINavigationController(rootViewController: TableViewController()) window?.makeKeyAndVisible() diff --git a/QuickTableViewController.xcodeproj/project.pbxproj b/QuickTableViewController.xcodeproj/project.pbxproj index ab6a1097..0c712b9f 100644 --- a/QuickTableViewController.xcodeproj/project.pbxproj +++ b/QuickTableViewController.xcodeproj/project.pbxproj @@ -722,6 +722,7 @@ }; B54A24252088816D00EEBA26 = { CreatedOnToolsVersion = 9.3; + LastSwiftMigration = 1000; ProvisioningStyle = Automatic; }; B54A242D2088816E00EEBA26 = { @@ -730,6 +731,7 @@ }; B54A24522088D44A00EEBA26 = { CreatedOnToolsVersion = 9.3; + LastSwiftMigration = 1000; ProvisioningStyle = Automatic; }; }; @@ -1462,7 +1464,7 @@ SDKROOT = appletvos; SKIP_INSTALL = YES; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; TARGETED_DEVICE_FAMILY = 3; TVOS_DEPLOYMENT_TARGET = 9.0; }; @@ -1492,7 +1494,7 @@ SDKROOT = appletvos; SKIP_INSTALL = YES; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; TARGETED_DEVICE_FAMILY = 3; TVOS_DEPLOYMENT_TARGET = 9.0; }; @@ -1570,7 +1572,7 @@ PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = appletvos; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; TARGETED_DEVICE_FAMILY = 3; TVOS_DEPLOYMENT_TARGET = 9.0; }; @@ -1596,7 +1598,7 @@ PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = appletvos; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 4.2; TARGETED_DEVICE_FAMILY = 3; TVOS_DEPLOYMENT_TARGET = 9.0; }; diff --git a/Source/Rows/SwitchRow.swift b/Source/Rows/SwitchRow.swift index 55bfef96..d6804ce7 100644 --- a/Source/Rows/SwitchRow.swift +++ b/Source/Rows/SwitchRow.swift @@ -97,7 +97,7 @@ open class SwitchRow: SwitchRowCompatible, Equatable { #elseif os(tvOS) /// Returns `.checkmark` when the `switchValue` is on, otherwise returns `.none`. - public var accessoryType: UITableViewCellAccessoryType { + public var accessoryType: UITableViewCell.AccessoryType { return switchValue ? .checkmark : .none } From ad972df7bcb6bb6036de4a02c3a9aa692e0d457d Mon Sep 17 00:00:00 2001 From: Aaron Brager Date: Sat, 6 Oct 2018 09:43:47 +0800 Subject: [PATCH 7/9] Add Swiftlint fix back in --- Example-iOS/AppDelegate.swift | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Example-iOS/AppDelegate.swift b/Example-iOS/AppDelegate.swift index c780991a..782d60e6 100644 --- a/Example-iOS/AppDelegate.swift +++ b/Example-iOS/AppDelegate.swift @@ -31,7 +31,9 @@ internal final class AppDelegate: UIResponder, UIApplicationDelegate { var window: UIWindow? + // swiftlint:disable line_length func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool { + // swiftlint:enable line_length if #available(iOS 9.0, *) { // See AppearanceViewController for the setups. From a492658575b01671f154cf0d985878a9c6511422 Mon Sep 17 00:00:00 2001 From: Ben Date: Sat, 6 Oct 2018 11:29:44 +0100 Subject: [PATCH 8/9] Disable SwiftLint:line_length rule --- .swiftlint.yml | 2 +- Example-iOS/AppDelegate.swift | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.swiftlint.yml b/.swiftlint.yml index 5cad63dc..13e5771b 100644 --- a/.swiftlint.yml +++ b/.swiftlint.yml @@ -3,6 +3,7 @@ disabled_rules: - force_cast - function_body_length - identifier_name + - line_length - vertical_whitespace opt_in_rules: - closure_end_indentation @@ -36,4 +37,3 @@ included: excluded: - Carthage - Pods -line_length: 192 diff --git a/Example-iOS/AppDelegate.swift b/Example-iOS/AppDelegate.swift index 782d60e6..c780991a 100644 --- a/Example-iOS/AppDelegate.swift +++ b/Example-iOS/AppDelegate.swift @@ -31,9 +31,7 @@ internal final class AppDelegate: UIResponder, UIApplicationDelegate { var window: UIWindow? - // swiftlint:disable line_length func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool { - // swiftlint:enable line_length if #available(iOS 9.0, *) { // See AppearanceViewController for the setups. From 9f3a52d4cb58024133c2ddbf319a1dc198836e06 Mon Sep 17 00:00:00 2001 From: Ben Date: Sat, 6 Oct 2018 11:40:34 +0100 Subject: [PATCH 9/9] Remove the duplicate test command from .travis.yml --- .travis.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6d1e0e0e..b505eb26 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,8 +1,5 @@ language: objective-c osx_image: xcode10 -matrix: - include: - - env: VERSION=latest cache: - bundler - cocoapods @@ -17,7 +14,6 @@ before_script: - if [ -n "$DANGER_GITHUB_API_TOKEN" ]; then bundle exec danger; fi script: - set -o pipefail - - xcodebuild clean build -workspace QuickTableViewController.xcworkspace -scheme QuickTableViewController-iOS -sdk iphonesimulator SWIFT_VERSION=4.2 | bundle exec xcpretty -c - bundle exec rake "test:ios[QuickTableViewController-iOS]" - bundle exec rake "test:tvos[QuickTableViewController-tvOS]" - bash <(curl -s https://codecov.io/bash) -cF ios -J "QuickTableViewController"