Skip to content

Commit d4207ed

Browse files
jakzalrquadling
authored andcommitted
Remove a hard dependency on the intl extension (#289)
Fixes #288. While #268 and #269 updated count() and isCountable() to now work with intl resources, #286 made that the whole beberlei/assert package now requires the intl extension to be installed. However, the intl extension dependency is a soft dependency. The package does not need intl for most of its features and can safely work without it.
1 parent 200ecc8 commit d4207ed

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

composer.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
},
4141
"require": {
4242
"php": "^7",
43-
"ext-intl": "*",
4443
"ext-simplexml": "*",
4544
"ext-mbstring": "*",
4645
"ext-ctype": "*",

tests/Assert/Tests/AssertTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1437,7 +1437,8 @@ public function testValidCount()
14371437
* @requires extension intl
14381438
*/
14391439
public function testValidCountWithIntlResourceBundle()
1440-
{ // Test ResourceBundle counting using resources generated for PHP testing of ResourceBundle
1440+
{
1441+
// Test ResourceBundle counting using resources generated for PHP testing of ResourceBundle
14411442
// https://github.com/php/php-src/commit/8f4337f2551e28d98290752e9ca99fc7f87d93b5
14421443
$this->assertTrue(Assertion::count(new ResourceBundle('en_US', __DIR__.'/_files/ResourceBundle'), 6));
14431444
}

0 commit comments

Comments
 (0)