Skip to content

Commit 3535532

Browse files
krugerkkrugerk
authored
Delete unused code from assorted files (#605)
## Summary just some dead code removal ## Validation built the app ran the tests
1 parent 67fffb9 commit 3535532

File tree

11 files changed

+0
-107
lines changed

11 files changed

+0
-107
lines changed

‎BeeKit/DateUtils.swift‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎BeeKit/HeathKit/StandHoursHealthKitMetric.swift‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import OSLog
44

55
class StandHoursHealthKitMetric : CategoryHealthKitMetric {
66
private let logger = Logger(subsystem: "com.beeminder.beeminder", category: "StandHoursHealthKitMetric")
7-
let hourInSeconds = 3600.0
87

98
init(humanText: String, databaseString: String, category: HealthKitCategory) {
109
super.init(humanText: humanText, databaseString: databaseString, category: category, hkSampleType: HKObjectType.categoryType(forIdentifier: .appleStandHour)!)

‎BeeKit/Managers/CurrentUserManager.swift‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ public actor CurrentUserManager {
2222
public static let willSignOut = NSNotification.Name(rawValue: "com.beeminder.willSignOutNotification")
2323
public static let failedSignIn = NSNotification.Name(rawValue: "com.beeminder.failedSignInNotification")
2424
public static let signedOut = NSNotification.Name(rawValue: "com.beeminder.signedOutNotification")
25-
public static let reset = NSNotification.Name(rawValue: "com.beeminder.resetNotification")
26-
public static let willReset = NSNotification.Name(rawValue: "com.beeminder.willResetNotification")
2725
public static let healthKitMetricRemoved = NSNotification.Name(rawValue: "com.beeminder.healthKitMetricRemovedNotification")
2826
}
2927

‎BeeKit/Util/Constants.swift‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,11 @@ public struct Constants {
1616
public static let graphHeight = 453
1717
public static let defaultFontSize = UIDevice.current.userInterfaceIdiom == .pad ? CGFloat(18) : CGFloat(14)
1818
public static let defaultTextFieldHeight = 44
19-
public static let savedMetricNotificationName = "hkMetricSaved"
20-
public static let removedMetricNotificationName = "hkMetricRemoved"
2119
public static let selectedGoalSortKey = "selectedGoalSort"
2220
public static let recentDataGoalSortString = "Recent Data"
2321
public static let nameGoalSortString = "Name"
2422
public static let pledgeGoalSortString = "Pledge"
2523
public static let urgencyGoalSortString = "Urgency"
26-
public static let healthKitUpdateDictionaryKey = "healthKitUpdateDictionary"
2724
public static let goalSortOptions = [Constants.urgencyGoalSortString, Constants.nameGoalSortString, Constants.pledgeGoalSortString, Constants.recentDataGoalSortString]
2825
public static let appGroupIdentifier = "group.beeminder.beeminder"
2926
}

‎BeeKit/Util/SynchronizedBox.swift‎

Lines changed: 0 additions & 26 deletions
This file was deleted.

‎BeeKitTests/BeeKitTests.swift‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎BeeKitTests/DaystampTests.swift‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import XCTest
22
@testable import BeeKit
33

44
final class DaystampTests: XCTestCase {
5-
var previousTimezone: TimeZone!
6-
75
let OneHourInSeconds = 60 * 60
86

97
func testFormatsAsString() throws {

‎BeeSwift.xcodeproj/project.pbxproj‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
E458C8052AD11BC8000DCA5C /* VersionManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = E5C161932423CE9F0045C90D /* VersionManager.swift */; };
6161
E458C8062AD11BCD000DCA5C /* GoalManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = E44CE782299338C500394E87 /* GoalManager.swift */; };
6262
E458C8082AD11BFB000DCA5C /* BeeDataPoint.swift in Sources */ = {isa = PBXBuildFile; fileRef = E4B0833C293810EB00A71564 /* BeeDataPoint.swift */; };
63-
E458C8092AD11C13000DCA5C /* SynchronizedBox.swift in Sources */ = {isa = PBXBuildFile; fileRef = E462BA2D29A31C3B00E80EF0 /* SynchronizedBox.swift */; };
6463
E458C80A2AD11C1C000DCA5C /* Constants.swift in Sources */ = {isa = PBXBuildFile; fileRef = A1C11B471B06F5D100D22871 /* Constants.swift */; };
6564
E458C80B2AD11C2B000DCA5C /* ServiceLocator.swift in Sources */ = {isa = PBXBuildFile; fileRef = E44CE7722993317B00394E87 /* ServiceLocator.swift */; };
6665
E458C80D2AD11C64000DCA5C /* Crypto.swift in Sources */ = {isa = PBXBuildFile; fileRef = A12BA9531AFFF21800AFEF32 /* Crypto.swift */; };
@@ -78,7 +77,6 @@
7877
E458C81A2AD11CB5000DCA5C /* WorkoutMinutesHealthKitMetric.swift in Sources */ = {isa = PBXBuildFile; fileRef = E4040D732A7B5F0E008E7D0E /* WorkoutMinutesHealthKitMetric.swift */; };
7978
E458C81B2AD11CD8000DCA5C /* UIColorExtension.swift in Sources */ = {isa = PBXBuildFile; fileRef = A1453B341AED9184006F48DA /* UIColorExtension.swift */; };
8079
E458C81C2AD11CDE000DCA5C /* UIFontExtension.swift in Sources */ = {isa = PBXBuildFile; fileRef = A1C170DF1BEEB3110018D32B /* UIFontExtension.swift */; };
81-
E458C81E2AD11D05000DCA5C /* DateUtils.swift in Sources */ = {isa = PBXBuildFile; fileRef = E46FF15A2984C522009F8C7A /* DateUtils.swift */; };
8280
E458C8202AD11D35000DCA5C /* SwiftyJSON in Frameworks */ = {isa = PBXBuildFile; productRef = E458C81F2AD11D35000DCA5C /* SwiftyJSON */; };
8381
E458C8222AD11D40000DCA5C /* Alamofire in Frameworks */ = {isa = PBXBuildFile; productRef = E458C8212AD11D40000DCA5C /* Alamofire */; };
8482
E458C8242AD11D7F000DCA5C /* KeychainSwift in Frameworks */ = {isa = PBXBuildFile; productRef = E458C8232AD11D7F000DCA5C /* KeychainSwift */; };
@@ -123,7 +121,6 @@
123121
E55760F526549D310076B95A /* AddDataIntentHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = E55760F426549D310076B95A /* AddDataIntentHandler.swift */; };
124122
E557610026549DD10076B95A /* AddDataIntentHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = E55760F426549D310076B95A /* AddDataIntentHandler.swift */; };
125123
E57BE6E92655EBE000BA540B /* BeeKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = E57BE6E02655EBD900BA540B /* BeeKit.framework */; };
126-
E57BE6F02655EBE000BA540B /* BeeKitTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = E57BE6EF2655EBE000BA540B /* BeeKitTests.swift */; };
127124
E57BE6F22655EBE000BA540B /* BeeKit.h in Headers */ = {isa = PBXBuildFile; fileRef = E57BE6E22655EBDA00BA540B /* BeeKit.h */; settings = {ATTRIBUTES = (Public, ); }; };
128125
E57BE6F52655EBE000BA540B /* BeeKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = E57BE6E02655EBD900BA540B /* BeeKit.framework */; };
129126
E57BE7042655EE1F00BA540B /* Config.swift in Sources */ = {isa = PBXBuildFile; fileRef = E55FEE6A23FF7552007C20B2 /* Config.swift */; };
@@ -290,9 +287,7 @@
290287
E457BE5C28C192B50012F5D0 /* IntentHandler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = IntentHandler.swift; sourceTree = "<group>"; };
291288
E46070EE2B36A4D900305DB4 /* User.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = User.swift; sourceTree = "<group>"; };
292289
E46070F72B3FEFD400305DB4 /* BeeminderPersistentContainer.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BeeminderPersistentContainer.swift; sourceTree = "<group>"; };
293-
E462BA2D29A31C3B00E80EF0 /* SynchronizedBox.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SynchronizedBox.swift; sourceTree = "<group>"; };
294290
E46DC80E2AA58DF20059FDFE /* PullToRefreshHint.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PullToRefreshHint.swift; sourceTree = "<group>"; };
295-
E46FF15A2984C522009F8C7A /* DateUtils.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DateUtils.swift; sourceTree = "<group>"; };
296291
E48E2711296B7548008013C0 /* TotalSleepMinutes.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TotalSleepMinutes.swift; sourceTree = "<group>"; };
297292
E48E2713296B75E4008013C0 /* TotalSleepMinutesTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TotalSleepMinutesTests.swift; sourceTree = "<group>"; };
298293
E48E2715296B9F4B008013C0 /* TimeAsleepHealthKitMetric.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TimeAsleepHealthKitMetric.swift; sourceTree = "<group>"; };
@@ -321,7 +316,6 @@
321316
E57BE6E22655EBDA00BA540B /* BeeKit.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BeeKit.h; sourceTree = "<group>"; };
322317
E57BE6E32655EBDA00BA540B /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
323318
E57BE6E82655EBDF00BA540B /* BeeKitTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BeeKitTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
324-
E57BE6EF2655EBE000BA540B /* BeeKitTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BeeKitTests.swift; sourceTree = "<group>"; };
325319
E57BE6F12655EBE000BA540B /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
326320
E5C161932423CE9F0045C90D /* VersionManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VersionManager.swift; sourceTree = "<group>"; };
327321
E5DF493624DC69A200260560 /* Config.swift.sample */ = {isa = PBXFileReference; lastKnownFileType = text; path = Config.swift.sample; sourceTree = "<group>"; };
@@ -444,7 +438,6 @@
444438
children = (
445439
A1C11B471B06F5D100D22871 /* Constants.swift */,
446440
A12BA9531AFFF21800AFEF32 /* Crypto.swift */,
447-
E462BA2D29A31C3B00E80EF0 /* SynchronizedBox.swift */,
448441
);
449442
path = Util;
450443
sourceTree = "<group>";
@@ -656,7 +649,6 @@
656649
E55FEE6A23FF7552007C20B2 /* Config.swift */,
657650
E5DF493624DC69A200260560 /* Config.swift.sample */,
658651
E4B0833C293810EB00A71564 /* BeeDataPoint.swift */,
659-
E46FF15A2984C522009F8C7A /* DateUtils.swift */,
660652
E45470272B60E24500EE648B /* Daystamp.swift */,
661653
E57BE6E32655EBDA00BA540B /* Info.plist */,
662654
E44CE7722993317B00394E87 /* ServiceLocator.swift */,
@@ -668,7 +660,6 @@
668660
E57BE6EE2655EBE000BA540B /* BeeKitTests */ = {
669661
isa = PBXGroup;
670662
children = (
671-
E57BE6EF2655EBE000BA540B /* BeeKitTests.swift */,
672663
E45470292B60E25C00EE648B /* DaystampTests.swift */,
673664
E57BE6F12655EBE000BA540B /* Info.plist */,
674665
);
@@ -1075,13 +1066,11 @@
10751066
E458C8052AD11BC8000DCA5C /* VersionManager.swift in Sources */,
10761067
E458C8142AD11C99000DCA5C /* QuantityHealthKitMetric.swift in Sources */,
10771068
E4D5BD5D2C5DFBA30007B0BE /* HealthKitMetricMonitor.swift in Sources */,
1078-
E458C8092AD11C13000DCA5C /* SynchronizedBox.swift in Sources */,
10791069
E458C8102AD11C87000DCA5C /* CategoryHealthKitMetric.swift in Sources */,
10801070
E458C8192AD11CB0000DCA5C /* StandHoursHealthKitMetric.swift in Sources */,
10811071
E45470282B60E24500EE648B /* Daystamp.swift in Sources */,
10821072
E458C8042AD11BC3000DCA5C /* SignedRequestManager.swift in Sources */,
10831073
E458C8162AD11CA2000DCA5C /* HealthKitError.swift in Sources */,
1084-
E458C81E2AD11D05000DCA5C /* DateUtils.swift in Sources */,
10851074
E4B0A33128C194C900055EA7 /* AddDataIntents.intentdefinition in Sources */,
10861075
E458C8132AD11C94000DCA5C /* HealthKitMetric.swift in Sources */,
10871076
E458C80F2AD11C80000DCA5C /* HealthKitConfig.swift in Sources */,
@@ -1121,7 +1110,6 @@
11211110
files = (
11221111
E454702A2B60E25C00EE648B /* DaystampTests.swift in Sources */,
11231112
E4B0A33228C194CA00055EA7 /* AddDataIntents.intentdefinition in Sources */,
1124-
E57BE6F02655EBE000BA540B /* BeeKitTests.swift in Sources */,
11251113
);
11261114
runOnlyForDeploymentPostprocessing = 0;
11271115
};

‎BeeSwift/Gallery/GalleryViewController.swift‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ class GalleryViewController: UIViewController, UICollectionViewDelegateFlowLayou
4040
let outofdateLabel = BSLabel()
4141
let searchBar = UISearchBar()
4242
var lastUpdated: Date?
43-
let maxSearchBarHeight: Int = 50
4443

4544
var goals : [Goal] = []
4645
var filteredGoals : [Goal] = []
@@ -291,19 +290,12 @@ class GalleryViewController: UIViewController, UICollectionViewDelegateFlowLayou
291290
func searchBarCancelButtonClicked(_ searchBar: UISearchBar) {
292291
self.toggleSearchBar()
293292
}
294-
295293

296294
func updateDeadbeatVisibility() {
297295
let isKnownDeadbeat = currentUserManager.user(context: viewContext)?.deadbeat == true
298296
self.deadbeatView.isHidden = !isKnownDeadbeat
299297
}
300298

301-
private let lastUpdatedDateFormatter: RelativeDateTimeFormatter = {
302-
let formatter = RelativeDateTimeFormatter()
303-
formatter.dateTimeStyle = .named
304-
return formatter
305-
}()
306-
307299
@objc func updateLastUpdatedLabel() {
308300
let lastUpdated = self.lastUpdated ?? .distantPast
309301

‎BeeSwift/GoalViewController.swift‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ class GoalViewController: UIViewController, UIScrollViewDelegate, DatapointTabl
3939
fileprivate var scrollView = UIScrollView()
4040
fileprivate var submitButton = BSButton()
4141
fileprivate let headerWidth = Double(1.0/3.0)
42-
fileprivate let viewGoalActivityType = "com.beeminder.viewGoal"
4342

4443
// date corresponding to the datapoint to be created
4544
private var date: Date = Date()

0 commit comments

Comments
 (0)