Skip to content

Read and write requestids for datapoints with HealthKit#419

Merged
theospears merged 1 commit intomasterfrom
id-for-datapoints
Dec 2, 2023
Merged

Read and write requestids for datapoints with HealthKit#419
theospears merged 1 commit intomasterfrom
id-for-datapoints

Conversation

@theospears
Copy link
Copy Markdown
Collaborator

This prepares for supporting point-by-point syncing of data from HealthKit. In particular

  1. HealthKit data sources now provide a requestid for the datapoints they generate
  2. We always read requestid from the server (now they are always sent)

This will start writing new IDs immediately, and in the future means we can use the IDs to sync when we have multiple datapoints per day.

Testing:

  • Deleted some existing data points, synced with apple heath, and checked they got requestids as expected
  • Checked the app can still update existing points via apple health
  • Confirmed data points still load without crashing

@theospears
Copy link
Copy Markdown
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@theospears theospears merged commit 3d6a31a into master Dec 2, 2023
@theospears theospears deleted the id-for-datapoints branch December 2, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant