Color safeSum in forest green as used in the Grayson Dot#535
Color safeSum in forest green as used in the Grayson Dot#535theospears merged 3 commits intobeeminder:masterfrom
Conversation
replaces if else with a switch for increased legibility
theospears
left a comment
theospears
left a comment
There was a problem hiding this comment.
The color parts of this look good. Less sure about the change to gray.
| public static let red: UIColor = .systemRed | ||
|
|
||
| public static let gray = UIColor(white: 0.7, alpha: 1.0) | ||
| public static let gray = UIColor.systemGray |
There was a problem hiding this comment.
I believe this is a somewhat darker color than the previous one (more like white: 0.5). Was that deliberate?
There was a problem hiding this comment.
The system gray one will adapt to the device's environment whereas the white 0.7 with alpha 1.0 one will not.
And since the app does not use the exact same colors the website uses for the dots, picking something easier to read (better contrast) instead, this MR does the same with the gray.
before
after
There was a problem hiding this comment.
I agree this is true in abstract, and for most system colors. It turns out systemGray is the same in both dark mode and light mode.
I'm not convinced having this universal gray really makes sense (e.g. perhaps backgrounds should be closer to the background color than borders are), but that seems like a problem for another day.
2 participants
Summary
The chart includes the Grayson Dot - a different color green applied to green dots with more than 7d buffer. The iOS app colors the
safeSumusing colors based on the colors of the dots. This text appears in both the gallery in a goal's cell as well as in the goal screen itself. Previously the same green was being used for allsafeSumwith asafeBufgreater than three.Validation
Ran app in the simulator using the new colors and logic. Made screenshots.
Fixes #206