From 73c88b85a4920c656bea4197c908af102b266820 Mon Sep 17 00:00:00 2001 From: bgard68 <30295154+bgard68@users.noreply.github.com> Date: Sun, 2 Aug 2026 11:29:43 -0500 Subject: [PATCH] build(ci): let the build checks report on every pull request MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Mirrors #83 on main, for the branch that would carry the API if it is ever switched in. A path-filtered check never reports on a pull request that misses its paths, and a required check that never reports blocks the merge for ever — so 'Build & Test' and 'Build API image & scan' could not be required here. That is how auto-merge landed two dependency bumps while the container build was failing, and left this branch unable to build its image until #82. Removed from pull_request only; the push trigger keeps its filter. --- .github/workflows/api-ci-cd.yml | 11 +++++------ .github/workflows/container-build.yml | 11 +++++------ .github/workflows/scripts-lint.yml | 11 +++++------ 3 files changed, 15 insertions(+), 18 deletions(-) diff --git a/.github/workflows/api-ci-cd.yml b/.github/workflows/api-ci-cd.yml index 3639019..c9cb07b 100644 --- a/.github/workflows/api-ci-cd.yml +++ b/.github/workflows/api-ci-cd.yml @@ -9,14 +9,13 @@ on: - 'TodoApp.sln' - 'Directory.Build.props' - '.github/workflows/api-ci-cd.yml' + # No paths filter on pull_request, deliberately. A path-filtered check never + # reports on a pull request that misses its paths, and a required check that + # never reports blocks the merge for ever — so these could not be required, + # which is how auto-merge landed two bumps here while this job was failing. + # The push trigger keeps its filter: no reason to rebuild on a docs edit. pull_request: branches: [ main ] - paths: - - 'src/**' - - 'tests/**' - - 'TodoApp.sln' - - 'Directory.Build.props' - - '.github/workflows/api-ci-cd.yml' workflow_dispatch: # Required for OIDC (federated) login to Azure — no stored password/publish-profile. diff --git a/.github/workflows/container-build.yml b/.github/workflows/container-build.yml index aac3da2..19c7257 100644 --- a/.github/workflows/container-build.yml +++ b/.github/workflows/container-build.yml @@ -18,14 +18,13 @@ on: - 'src/**' - 'Directory.Build.props' - '.github/workflows/container-build.yml' + # No paths filter on pull_request, deliberately. A path-filtered check never + # reports on a pull request that misses its paths, and a required check that + # never reports blocks the merge for ever — so these could not be required, + # which is how auto-merge landed two bumps here while this job was failing. + # The push trigger keeps its filter: no reason to rebuild on a docs edit. pull_request: branches: [ main, dapper ] - paths: - - 'Dockerfile.api' - - 'docker-compose.yml' - - 'src/**' - - 'Directory.Build.props' - - '.github/workflows/container-build.yml' schedule: # Base images pick up CVEs without the Dockerfile changing. - cron: '23 5 * * 1' diff --git a/.github/workflows/scripts-lint.yml b/.github/workflows/scripts-lint.yml index e663383..3306cb4 100644 --- a/.github/workflows/scripts-lint.yml +++ b/.github/workflows/scripts-lint.yml @@ -17,14 +17,13 @@ on: - '**/*.md' - 'src/**' - '.github/workflows/scripts-lint.yml' + # No paths filter on pull_request, deliberately. A path-filtered check never + # reports on a pull request that misses its paths, and a required check that + # never reports blocks the merge for ever — so these could not be required, + # which is how auto-merge landed two bumps here while this job was failing. + # The push trigger keeps its filter: no reason to rebuild on a docs edit. pull_request: branches: [ main, dapper ] - paths: - - '**/*.sh' - - '**/*.ps1' - - '**/*.md' - - 'src/**' - - '.github/workflows/scripts-lint.yml' workflow_dispatch: permissions: