Replaced RunInTransaction with RunInSavepointTransaction

Author: Robert Ros

src/SQLite.cs

@@ -855,31 +855,6 @@ public void Commit ()
 			// Do nothing on a commit with no open transaction
 		}
 
-
-		/// <summary>
-		/// Executes <param name="action"> within a transaction and automatically rollsback the transaction
-		/// if an exception occurs. The exception is rethrown.
-		/// </summary>
-		/// <param name="action">
-		/// The <see cref="Action"/> to perform within a transaction. <param name="action"> can contain any number
-		/// of operations on the connection but should never call <see cref="BeginTransaction"/>,
-		/// <see cref="Rollback"/>, or <see cref="Commit"/>.
-		/// </param>
-		public void RunInTransaction (Action action)
-		{
-			if (_trasactionDepth != 0) {
-				throw new InvalidOperationException ("The connection must not already be in a transaction when RunInTransaction is called");
-			}
-			try {
-				BeginTransaction ();
-				action ();
-				Commit ();
-			} catch (Exception) {
-				Rollback ();
-				throw;
-			}
-		}
-		
 		/// <summary>
 		/// Executes <param name="action"> within a (possibly nested) transaction by wrapping it in a SAVEPOINT. If an
 		/// exception occurs the whole transaction is rolled back, not just the current savepoint. The exception
@@ -890,7 +865,7 @@ public void RunInTransaction (Action action)
 		/// of operations on the connection but should never call <see cref="BeginTransaction"/> or
 		/// <see cref="Commit"/>.
 		/// </param>
-		public void RunInSavepointTransaction (Action action)
+		public void RunInTransaction (Action action)
 		{
 			try {
 				var savePoint = SaveTransactionPoint ();

tests/TransactionTest.cs

@@ -63,7 +63,7 @@ public void TearDown()
 		[Test]
 		public void SuccessfulSavepointTransaction()
 		{
-			db.RunInSavepointTransaction(() => {
+			db.RunInTransaction(() => {
 				db.Delete(testObjects[0]);
 				db.Delete(testObjects[1]);
 				db.Insert(new TestObj());
@@ -76,7 +76,7 @@ public void SuccessfulSavepointTransaction()
 		public void FailSavepointTransaction()
 		{
 			try {
-				db.RunInSavepointTransaction(() => {
+				db.RunInTransaction(() => {
 					db.Delete(testObjects[0]);
 
 					throw new TransactionTestException();
@@ -91,10 +91,10 @@ public void FailSavepointTransaction()
 		[Test]
 		public void SuccessfulNestedSavepointTransaction()
 		{
-			db.RunInSavepointTransaction(() => {
+			db.RunInTransaction(() => {
 				db.Delete(testObjects[0]);
 
-				db.RunInSavepointTransaction(() => {
+				db.RunInTransaction(() => {
 					db.Delete(testObjects[1]);
 				});
 			});
@@ -106,10 +106,10 @@ public void SuccessfulNestedSavepointTransaction()
 		public void FailNestedSavepointTransaction()
 		{
 			try {
-				db.RunInSavepointTransaction(() => {
+				db.RunInTransaction(() => {
 					db.Delete(testObjects[0]);
 
-					db.RunInSavepointTransaction(() => {
+					db.RunInTransaction(() => {
 						db.Delete(testObjects[1]);
 
 						throw new TransactionTestException();