fix(core): file size diagnostic severity (#9980)

Author: ematipico

.changeset/every-poets-throw.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#9941](https://github.com/biomejs/biome/issues/9941): Biome now emits a `warning` diagnostic when a file exceed the `files.maxSize` limit.

crates/biome_cli/tests/commands/check.rs

@@ -3665,3 +3665,37 @@ fn check_tab_alignment_in_diff_output() {
         result,
     ));
 }
+
+#[test]
+fn file_too_large_error_on_warnings() {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+    fs.insert(Utf8PathBuf::from("biome.json"), CONFIG_FILE_SIZE_LIMIT);
+    // This file exceeds the limit
+    let large_file = Utf8Path::new("large.js");
+    fs.insert(large_file.into(), "statement1();\nstatement2();");
+    // This file is within the limit
+    let small_file = Utf8Path::new("small.js");
+    fs.insert(small_file.into(), "a;\n");
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(
+            [
+                "check",
+                "--error-on-warnings",
+                large_file.as_str(),
+                small_file.as_str(),
+            ]
+            .as_slice(),
+        ),
+    );
+    assert!(result.is_err(), "run_cli returned {result:?}");
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "file_too_large_error_on_warnings",
+        fs,
+        console,
+        result,
+    ));
+}

crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_too_large_limit_check.snap

@@ -47,13 +47,13 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
 ```block
 test.js check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  i The size of the file is 13 B, which exceeds the configured maximum of 1 B for this project.
+  ! The size of the file is 13 B, which exceeds the configured maximum of 1 B for this project.
     Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.includes` to ignore the file.
   
 
 ```
 
 ```block
 Checked 0 files in <TIME>. No fixes applied.
-Found 1 info.
+Found 1 warning.
 ```

crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_too_large_limit_format.snap

@@ -47,13 +47,13 @@ format ━━━━━━━━━━━━━━━━━━━━━━━━
 ```block
 test.js format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  i The size of the file is 13 B, which exceeds the configured maximum of 1 B for this project.
+  ! The size of the file is 13 B, which exceeds the configured maximum of 1 B for this project.
     Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.includes` to ignore the file.
   
 
 ```
 
 ```block
 Checked 0 files in <TIME>. No fixes applied.
-Found 1 info.
+Found 1 warning.
 ```

crates/biome_cli/tests/snapshots/main_commands_check/file_too_large.snap

@@ -24,13 +24,13 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
 ```block
 check.js check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  i The size of the file is 1.0 MiB, which exceeds the configured maximum of 1.0 MiB for this project.
+  ! The size of the file is 1.0 MiB, which exceeds the configured maximum of 1.0 MiB for this project.
     Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.includes` to ignore the file.
   
 
 ```
 
 ```block
 Checked 0 files in <TIME>. No fixes applied.
-Found 1 info.
+Found 1 warning.
 ```

crates/biome_cli/tests/snapshots/main_commands_check/file_too_large_cli_limit.snap

@@ -31,13 +31,13 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
 ```block
 check.js check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  i The size of the file is 27 B, which exceeds the configured maximum of 16 B for this project.
+  ! The size of the file is 27 B, which exceeds the configured maximum of 16 B for this project.
     Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.includes` to ignore the file.
   
 
 ```
 
 ```block
 Checked 0 files in <TIME>. No fixes applied.
-Found 1 info.
+Found 1 warning.
 ```

crates/biome_cli/tests/snapshots/main_commands_check/file_too_large_config_limit.snap

@@ -41,13 +41,13 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
 ```block
 check.js check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  i The size of the file is 27 B, which exceeds the configured maximum of 16 B for this project.
+  ! The size of the file is 27 B, which exceeds the configured maximum of 16 B for this project.
     Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.includes` to ignore the file.
   
 
 ```
 
 ```block
 Checked 0 files in <TIME>. No fixes applied.
-Found 1 info.
+Found 1 warning.
 ```

crates/biome_cli/tests/snapshots/main_commands_check/file_too_large_error_on_warnings.snap

@@ -0,0 +1,54 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "files": {
+    "maxSize": 16
+  }
+}
+```
+
+## `large.js`
+
+```js
+statement1();
+statement2();
+```
+
+## `small.js`
+
+```js
+a;
+
+```
+
+# Termination Message
+
+```block
+check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × Some warnings were emitted while running checks.
+  
+
+
+```
+
+# Emitted Messages
+
+```block
+large.js check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! The size of the file is 27 B, which exceeds the configured maximum of 16 B for this project.
+    Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.includes` to ignore the file.
+  
+
+```
+
+```block
+Checked 1 file in <TIME>. No fixes applied.
+Found 1 warning.
+```

crates/biome_cli/tests/snapshots/main_commands_ci/file_too_large.snap

@@ -24,13 +24,13 @@ ci ━━━━━━━━━━━━━━━━━━━━━━━━━
 ```block
 ci.js ci ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  i The size of the file is 1.0 MiB, which exceeds the configured maximum of 1.0 MiB for this project.
+  ! The size of the file is 1.0 MiB, which exceeds the configured maximum of 1.0 MiB for this project.
     Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.includes` to ignore the file.
   
 
 ```
 
 ```block
 Checked 0 files in <TIME>. No fixes applied.
-Found 1 info.
+Found 1 warning.
 ```

crates/biome_cli/tests/snapshots/main_commands_ci/file_too_large_cli_limit.snap

@@ -31,13 +31,13 @@ ci ━━━━━━━━━━━━━━━━━━━━━━━━━
 ```block
 ci.js ci ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  i The size of the file is 27 B, which exceeds the configured maximum of 16 B for this project.
+  ! The size of the file is 27 B, which exceeds the configured maximum of 16 B for this project.
     Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.includes` to ignore the file.
   
 
 ```
 
 ```block
 Checked 0 files in <TIME>. No fixes applied.
-Found 1 info.
+Found 1 warning.
 ```