perf(noMagicNumbers): reduce allocations (#9982)

dyc3 · autofix-ci[bot] · ematipico · web-flow · commit d6bdf4a91df0 · 2026-04-14T09:55:18.000-04:00
Co-authored-by: autofix-ci[bot] &lt;114827586+autofix-ci[bot]@users.noreply.github.com&gt;
Co-authored-by: Emanuele Stoppa &lt;my.burning@gmail.com&gt;
Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;
diff --git a/.changeset/odd-wasps-fly.md b/.changeset/odd-wasps-fly.md
@@ -0,0 +1,6 @@
+---
+"@biomejs/biome": patch
+---
+
+Improved performance of [noMagicNumbers](https://biomejs.dev/linter/rules/no-magic-numbers/).
+Biome now maps ESLint `no-magic-numbers` sources more accurately during `biome migrate eslint`.
diff --git a/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs b/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs
diff --git a/crates/biome_js_analyze/src/lint/style/no_magic_numbers.rs b/crates/biome_js_analyze/src/lint/style/no_magic_numbers.rs
@@ -55,7 +55,7 @@ declare_lint_rule! {
         version: "2.1.0",
         name: "noMagicNumbers",
         language: "ts",
-        sources: &[RuleSource::EslintTypeScript("no-magic-numbers").same()],
+        sources: &[RuleSource::Eslint("no-magic-numbers").inspired(), RuleSource::EslintTypeScript("no-magic-numbers").same()],
         recommended: false,
     }
 }
@@ -407,5 +407,9 @@ const ALWAYS_IGNORED_IN_ARITHMETIC_OPERATIONS: &[&str] = &[
 ];
 
 fn is_allowed_number(numeric_literal: &AnyJsNumericLiteral) -> bool {
-    ALWAYS_IGNORED_IN_ARITHMETIC_OPERATIONS.contains(&numeric_literal.to_trimmed_string().as_str())
+    match numeric_literal {
+        AnyJsNumericLiteral::JsNumberLiteralExpression(expr) => expr.value_token(),
+        AnyJsNumericLiteral::JsBigintLiteralExpression(expr) => expr.value_token(),
+    }
+    .is_ok_and(|token| ALWAYS_IGNORED_IN_ARITHMETIC_OPERATIONS.contains(&token.text_trimmed()))
 }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ declare_lint_rule! {`
`55`	`55`	`version: "2.1.0",`
`56`	`56`	`name: "noMagicNumbers",`
`57`	`57`	`language: "ts",`
`58`		`- sources: &[RuleSource::EslintTypeScript("no-magic-numbers").same()],`
	`58`	`+ sources: &[RuleSource::Eslint("no-magic-numbers").inspired(), RuleSource::EslintTypeScript("no-magic-numbers").same()],`
`59`	`59`	`recommended: false,`
`60`	`60`	`}`
`61`	`61`	`}`
`@@ -407,5 +407,9 @@ const ALWAYS_IGNORED_IN_ARITHMETIC_OPERATIONS: &[&str] = &[`
`407`	`407`	`];`
`408`	`408`
`409`	`409`	`fn is_allowed_number(numeric_literal: &AnyJsNumericLiteral) -> bool {`
`410`		`- ALWAYS_IGNORED_IN_ARITHMETIC_OPERATIONS.contains(&numeric_literal.to_trimmed_string().as_str())`
	`410`	`+ match numeric_literal {`
	`411`	`+ AnyJsNumericLiteral::JsNumberLiteralExpression(expr) => expr.value_token(),`
	`412`	`+ AnyJsNumericLiteral::JsBigintLiteralExpression(expr) => expr.value_token(),`
	`413`	`+ }`
	`414`	`+ .is_ok_and(\|token\| ALWAYS_IGNORED_IN_ARITHMETIC_OPERATIONS.contains(&token.text_trimmed()))`
`411`	`415`	`}`