From a411455bbec0eacde7078b0bac74791db6bf2604 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Mon, 26 Sep 2022 15:26:41 -0300 Subject: [PATCH 1/2] Fix: use type of Number for amount --- packages/crypto-wallet-core/src/transactions/erc20/index.ts | 6 +++--- packages/crypto-wallet-core/src/transactions/eth/index.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/crypto-wallet-core/src/transactions/erc20/index.ts b/packages/crypto-wallet-core/src/transactions/erc20/index.ts index c05d43bc2cb..7b054ca5035 100644 --- a/packages/crypto-wallet-core/src/transactions/erc20/index.ts +++ b/packages/crypto-wallet-core/src/transactions/erc20/index.ts @@ -12,7 +12,7 @@ export class ERC20TxProvider extends ETHTxProvider { } create(params: { - recipients: Array<{ address: string; amount: string }>; + recipients: Array<{ address: string; amount: number }>; nonce: number; gasPrice: number; data: string; @@ -24,13 +24,13 @@ export class ERC20TxProvider extends ETHTxProvider { }) { const { tokenAddress, contractAddress } = params; const data = this.encodeData(params); - const recipients = [{ address: contractAddress || tokenAddress, amount: '0' }]; + const recipients = [{ address: contractAddress || tokenAddress, amount: 0 }]; const newParams = { ...params, recipients, data }; return super.create(newParams); } encodeData(params: { - recipients: Array<{ address: string; amount: string }>; + recipients: Array<{ address: string; amount: number }>; tokenAddress: string; contractAddress?: string; }) { diff --git a/packages/crypto-wallet-core/src/transactions/eth/index.ts b/packages/crypto-wallet-core/src/transactions/eth/index.ts index adfb49ce97d..3a829aab755 100644 --- a/packages/crypto-wallet-core/src/transactions/eth/index.ts +++ b/packages/crypto-wallet-core/src/transactions/eth/index.ts @@ -7,7 +7,7 @@ const utils = require('web3-utils'); const { toBN } = Web3.utils; export class ETHTxProvider { create(params: { - recipients: Array<{ address: string; amount: string }>; + recipients: Array<{ address: string; amount: number }>; nonce: number; gasPrice: number; data: string; From 277d9f1e36a0036830325d488d50c54107b4e0e5 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Mon, 26 Sep 2022 15:33:09 -0300 Subject: [PATCH 2/2] Replaces typeof string by number --- .../crypto-wallet-core/src/transactions/eth-multisig/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/crypto-wallet-core/src/transactions/eth-multisig/index.ts b/packages/crypto-wallet-core/src/transactions/eth-multisig/index.ts index 86df3054d56..6eccedc89f5 100644 --- a/packages/crypto-wallet-core/src/transactions/eth-multisig/index.ts +++ b/packages/crypto-wallet-core/src/transactions/eth-multisig/index.ts @@ -11,7 +11,7 @@ export class ETHMULTISIGTxProvider extends ETHTxProvider { } create(params: { - recipients: Array<{ address: string; amount: string }>; + recipients: Array<{ address: string; amount: number }>; nonce: number; gasPrice: number; data: string; @@ -21,7 +21,7 @@ export class ETHMULTISIGTxProvider extends ETHTxProvider { chainId?: number; }) { const { multisigContractAddress } = params; - const recipients = [{ address: multisigContractAddress, amount: '0' }]; + const recipients = [{ address: multisigContractAddress, amount: 0 }]; const newParams = { ...params, recipients }; return super.create(newParams); }