fix so many tests - 100% coverage again

Author: bowheart

.babelrc

@@ -1,6 +1,6 @@
 {
   "plugins": ["@babel/transform-typescript"],
   "presets": [
-    ["@babel/env", { "modules": false }]
+    ["@babel/env"]
   ]
 }

docs/guides/metaChains.md

@@ -17,9 +17,9 @@ Meta chains are a standard format for meta data. Let's metafy this action:
 
 ```javascript
 const metafiedAddTodoAction = {
-  metaType: 'instructionToAllInspectors',
-  metaPayload: [ 'be', 'the', 'best' ],
-  action: {
+  metaType: 'instructionToEffectsSubscribers',
+  metaData: [ 'be', 'the', 'best' ],
+  payload: {
     type: 'addTodo',
     payload: 'make a bigger meta chain'
   }
@@ -28,17 +28,17 @@ const metafiedAddTodoAction = {
 
 A meta chain is a singly linked list composed of [meta chain nodes](/docs/types/MetaChainNode.md). The last node in the chain must be a normal [action object](/docs/types/Action.md). All other nodes in the chain (if any) must be [meta nodes](/docs/types/MetaNode.md).
 
-A meta node is very similar to a normal action object. It's an object with required `metaType` and `action` properties and an optional `metaPayload` property:
+A meta node is very similar to a normal action object. It's an object with required `metaType` and `action` properties and an optional `metaData` property:
 
 ```typescript
 interface MetaNode {
   metaType: string,
-  metaPayload?: any,
-  action: MetaChainNode
+  metaData?: any,
+  payload: MetaChainNode
 }
 ```
 
-A meta node's `action` property holds the next link in the chain.
+A meta node's `payload` property holds the next link in the chain.
 
 ## Why meta chains?
 

docs/guides/storeComposition.md

@@ -320,19 +320,19 @@ storeC.dispatch(increment())
 
   Store B inspector received action {
     metaType: '@@zedux/delegate',
-    metaPayload: [ 'nested', 'store' ],
-    action: {
+    metaData: [ 'nested', 'store' ],
+    payload: {
       type: 'increment'
     }
   }
 
   Root Store inspector received action {
     metaType: '@@zedux/delegate',
-    metaPayload: [ 'b' ],
-    action: {
+    metaData: [ 'b' ],
+    payload: {
       metaType: '@@zedux/delegate',
-      metaPayload: [ 'nested', 'store' ],
-      action: {
+      metaData: [ 'nested', 'store' ],
+      payload: {
         type: 'increment'
       }
     }

docs/guides/theInspectorLayer.md

@@ -43,8 +43,8 @@ childStore.dispatch(() => 'c')
 /*
   {
     metaType: '@@zedux/delegate',
-    metaPayload: [],
-    action: { type: '@@zedux/hydrate', payload: 'c' }
+    metaData: [],
+    payload: { type: '@@zedux/hydrate', payload: 'c' }
   }
 */
 
@@ -55,8 +55,8 @@ childStore.dispatch({
 /*
   {
     metaType: '@@zedux/delegate',
-    metaPayload: [],
-    action: { type: 'cool-action', payload: 'd' }
+    metaData: [],
+    payload: { type: 'cool-action', payload: 'd' }
   }
 */
 ```

docs/types/Action.md

@@ -1,6 +1,6 @@
 # Action
 
-An action is a plain object containing a `type` property and optional `payload` property. While this interface can be extended, actions should never contain `metaType`, `metaPayload`, or `action` properties, as these are reserved for [meta nodes](/docs/types/MetaNode.md).
+An action is a plain object containing a `type` property and optional `payload` property. While `type` is required, `payload` is optional and can be replaced with whatever standard you wish.
 
 ## Definition
 
@@ -12,6 +12,7 @@ interface Action<T extends string> {
 ```
 
 **type** - Some string that identifies this action. Avoid using names starting with `'@@zedux/'` as these are reserved for internal Zedux action types.
+**payload** - optional - Literally anything. Just a standard.
 
 ## Notes
 

docs/types/MetaNode.md

@@ -1,21 +1,31 @@
 # MetaNode
 
-A meta node is a node in a meta chain that defines meta data for the action it wraps. There are a few [built-in meta types](/docs/api/metaTypes.md), but you can use custom types as well.
+A meta node wraps an action in meta data. It is a node in a meta chain. There are a few [built-in meta types](/docs/api/metaTypes.md), but you can use custom types as well.
 
 ## Definition
 
-```typescript
+```ts
 interface MetaNode {
   metaType: string,
-  metaPayload?: any,
-  action: MetaChainNode
+  metaData?: any,
+  payload: MetaChainNode
 }
 ```
 
 **metaType** - Some string that identifies this meta node. Analogous to the `type` property of [actions](/docs/types/Action.md). Avoid using names starting with `'@@zedux/'` as these are reserved for internal Zedux meta types.
 
-**metaPayload** - Optional - Can be literally anything.
+**metaData** - Optional - Can be literally anything.
 
-**action** - The next node in the chain. So named because the last node in the chain must be an [action](/docs/types/Action.md) object. All meta nodes therefore effectively "wrap" the action in meta data.
+**payload** - The next node in the chain. The last meta node in the chain must specify the wrapped action as its `payload` property.
 
 ## Notes
+
+Zedux uses meta nodes internally to handle the intricacies of store composition. But you can use them too. A good use case is to add extra debugging information to dispatched actions:
+
+```js
+store.dispatch({
+  metaType: 'debugInfo',
+  metaData: 'dispatched from the login form',
+  payload: someActor()
+})
+```

index.d.ts

@@ -42,8 +42,8 @@ export interface Inspector {
 
 export interface MetaNode {
   metaType: string,
-  metaPayload?: any,
-  action: MetaChainNode
+  metaData?: any,
+  payload: MetaChainNode
 }
 
 

rollup.config.js

@@ -7,7 +7,11 @@ const env = process.env.NODE_ENV
 
 const plugins = [
   babel({
-    exclude: 'node_modules/**'
+    exclude: 'node_modules/**',
+    plugins: ['@babel/transform-typescript'],
+    presets: [
+      ['@babel/env', { modules: false }]
+    ]
   }),
 
   replace({

src/api/createStore.js

@@ -50,28 +50,16 @@ export const createStore = initialHierarchy => {
 
     assertIsPlainObject(action, 'Action')
 
-    const delegateReceipt = delegate(currentDiffTree, action)
+    const delegateReply = delegate(currentDiffTree, action)
 
-    if (delegateReceipt) {
+    if (delegateReply) {
       return {
-        ...delegateReceipt,
+        ...delegateReply,
         state: currentState
       }
     }
 
-    const unwrappedAction = removeAllMeta(action)
-
-    assertIsValidAction(unwrappedAction)
-
-    if (unwrappedAction.type === actionTypes.HYDRATE) {
-      return dispatchHydration(unwrappedAction.payload)
-    }
-
-    if (unwrappedAction.type === actionTypes.PARTIAL_HYDRATE) {
-      return setState(unwrappedAction.payload)
-    }
-
-    return dispatchAction(action, unwrappedAction)
+    return routeAction(action)
   }
 
 
@@ -146,10 +134,6 @@ export const createStore = initialHierarchy => {
     Throws an error if called from the reducer layer.
   */
   const setState = partialStateTree => {
-    if (isDispatching) {
-      throw new Error(invalidAccess('store.setState()'))
-    }
-
     const newState = mergeStateTrees(
       currentState,
       partialStateTree,
@@ -176,23 +160,23 @@ export const createStore = initialHierarchy => {
 
     if (subscriberObj.next) {
       assert(
-        typeof subscriber.next === 'function',
+        typeof subscriberObj.next === 'function',
         getError('subscriberNext'),
         subscriberObj.next
       )
     }
 
     if (subscriberObj.error) {
       assert(
-        typeof subscriber.error === 'function',
+        typeof subscriberObj.error === 'function',
         getError('subscriberError'),
         subscriberObj.error
       )
     }
 
     if (subscriberObj.effects) {
       assert(
-        typeof subscriber.effects === 'function',
+        typeof subscriberObj.effects === 'function',
         getError('subscriberEffects'),
         subscriberObj.effects
       )
@@ -235,7 +219,7 @@ export const createStore = initialHierarchy => {
   }
 
 
-  function dispatchAction(action, unwrappedAction) {
+  function dispatchAction(action, unwrappedAction, rootState = currentState) {
     if (isDispatching) {
       throw new Error(invalidAccess('dispatch(), hydrate(), setState()'))
     }
@@ -244,15 +228,15 @@ export const createStore = initialHierarchy => {
 
     const effects = []
     let error = null
-    let newState = currentState
+    let newState = rootState
 
     if (!hasMeta(action, metaTypes.INHERIT)) {
       effects.push(getDispatchEffect(action))
     }
 
     try {
       if (!hasMeta(action, metaTypes.SKIP_REDUCERS)) {
-        newState = dispatchToReducers(unwrappedAction)
+        newState = dispatchToReducers(unwrappedAction, rootState)
       }
 
       if (!hasMeta(action, metaTypes.SKIP_EFFECTS)) {
@@ -269,7 +253,7 @@ export const createStore = initialHierarchy => {
     return {
       effects,
       error,
-      state: currentState
+      state: newState
     }
   }
 
@@ -295,7 +279,7 @@ export const createStore = initialHierarchy => {
     // as the metaData.
 
     // Propagate the change to child stores and allow for effects.
-    return dispatchAction(action, action)
+    return dispatchAction(action, action, newState)
   }
 
 
@@ -308,7 +292,7 @@ export const createStore = initialHierarchy => {
 
   function getDispatchEffect(action) {
     return {
-      type: effectTypes.DISPATCH,
+      effectType: effectTypes.DISPATCH,
       payload: action
     }
   }
@@ -325,11 +309,11 @@ export const createStore = initialHierarchy => {
 
     assertAreValidEffects(receivedEffects)
 
-    return receivedEffects
+    return receivedEffects || []
   }
 
 
-  function dispatchToReducers(action, rootState = currentState) {
+  function dispatchToReducers(action, rootState) {
     return rootReactor
       ? rootReactor(rootState, action)
       : rootState
@@ -398,6 +382,24 @@ export const createStore = initialHierarchy => {
   }
 
 
+  function routeAction(action) {
+    const unwrappedAction = removeAllMeta(action)
+
+    assertIsValidAction(unwrappedAction)
+    const canHydrate = !hasMeta(action, metaTypes.SKIP_REDUCERS)
+
+    if (unwrappedAction.type === actionTypes.HYDRATE && canHydrate) {
+      return dispatchHydration(unwrappedAction.payload)
+    }
+
+    if (unwrappedAction.type === actionTypes.PARTIAL_HYDRATE && canHydrate) {
+      return setState(unwrappedAction.payload)
+    }
+
+    return dispatchAction(action, unwrappedAction)
+  }
+
+
   const store = {
     dispatch,
     getState,
@@ -406,7 +408,7 @@ export const createStore = initialHierarchy => {
     setState,
     subscribe,
     use,
-    [$$observable]: () => store,
+    ['@@observable']: () => store,
     $$typeof: STORE_IDENTIFIER
   }
 

src/api/state.js

@@ -6,18 +6,18 @@ import { assertAreFunctions } from '../utils/errors'
   Creates a Zedux state.
 
   A State is just a fancy actor that contains details about
-  how it should be processed - enter and leave hooks.
+  how it creates side effects.
 
   A Zedux state is just a state with a few special methods for
-  creating the processing hooks.
+  creating the enter and leave hooks.
 */
 export const state = createActorCreator(createState)
 
 
 /**
   Partially applies state() with one or more namespace nodes.
 
-  This will prefix all actors created with the bound state() function
+  This will prefix all states created with the bound state() function
   with the given namespace (joined by slashes - "/").
 */
 state.namespace = function(...namespaceNodes) {
@@ -37,10 +37,10 @@ function createState(stateName) {
 
 
   /**
-    Sets the `enter` processing hook for this state.
+    Sets the `enter` side effect hook for this state.
 
     This hook should be called the very next time the store's
-    processor layer is hit after the reducer layer makes the
+    side effects layer is hit after the reducer layer makes the
     machine enter this state.
   */
   zeduxState.onEnter = func => {
@@ -53,10 +53,10 @@ function createState(stateName) {
 
 
   /**
-    Sets the `leave` processing hook for this state.
+    Sets the `leave` side effect hook for this state.
 
     This hook should be called the very next time the store's
-    processor layer is hit after the reducer layer makes the
+    side effects layer is hit after the reducer layer makes the
     machine leave this state.
   */
   zeduxState.onLeave = func => {