[CodeFactor] Apply fixes to commit 0394c67

Author: code-factor

Sources/MistKit/Service/CloudKitService+WriteOperations.swift

@@ -209,7 +209,7 @@ extension CloudKitService {
     using uploader: AssetUploader? = nil
   ) async throws(CloudKitError) -> AssetUploadReceipt {
     // Validate data size (CloudKit limit is 15 MB)
-    let maxSize: Int = 15 * 1024 * 1024 // 15 MB
+    let maxSize: Int = 15 * 1_024 * 1_024 // 15 MB
     guard data.count <= maxSize else {
       throw CloudKitError.httpErrorWithRawResponse(
         statusCode: 413,

Tests/MistKitTests/Service/AssetUploadTokenTests.swift

@@ -88,7 +88,7 @@ internal struct AssetUploadTokenTests {
   internal func assetUploadReceiptInitializesWithAllFields() {
     let asset = FieldValue.Asset(
       fileChecksum: "abc123",
-      size: 1024,
+      size: 1_024,
       referenceChecksum: "ref456",
       wrappingKey: "wrap789",
       receipt: "receipt-token-xyz",
@@ -102,7 +102,7 @@ internal struct AssetUploadTokenTests {
     )
 
     #expect(result.asset.fileChecksum == "abc123")
-    #expect(result.asset.size == 1024)
+    #expect(result.asset.size == 1_024)
     #expect(result.asset.receipt == "receipt-token-xyz")
     #expect(result.recordName == "test-record")
     #expect(result.fieldName == "testField")

Tests/MistKitTests/Service/CloudKitServiceUploadTests+ErrorHandling.swift

@@ -42,7 +42,7 @@ extension CloudKitServiceUploadTests {
         return
       }
       let service = try await CloudKitServiceUploadTests.makeAuthErrorService()
-      let testData = Data(count: 1024)
+      let testData = Data(count: 1_024)
 
       do {
         _ = try await service.uploadAssets(

Tests/MistKitTests/Service/CloudKitServiceUploadTests+Helpers.swift

@@ -40,7 +40,7 @@ extension CloudKitServiceUploadTests {
 
   /// Create a mock asset uploader that returns a successful upload response
   internal static func makeMockAssetUploader() -> AssetUploader {
-    { data, url in
+    { data, _ in
       let response = """
       {
         "singleFile": {

Tests/MistKitTests/Service/CloudKitServiceUploadTests+SuccessCases.swift

@@ -42,7 +42,7 @@ extension CloudKitServiceUploadTests {
         return
       }
       let service = try await CloudKitServiceUploadTests.makeSuccessfulUploadService(tokenCount: 1)
-      let testData = Data(count: 1024)  // 1 KB of test data
+      let testData = Data(count: 1_024)  // 1 KB of test data
 
       let result = try await service.uploadAssets(
         data: testData,
@@ -63,7 +63,7 @@ extension CloudKitServiceUploadTests {
         return
       }
       let service = try await CloudKitServiceUploadTests.makeSuccessfulUploadService(tokenCount: 1)
-      let testData = Data(count: 2048)
+      let testData = Data(count: 2_048)
 
       let result = try await service.uploadAssets(
         data: testData,
@@ -84,7 +84,7 @@ extension CloudKitServiceUploadTests {
         return
       }
       let service = try await CloudKitServiceUploadTests.makeSuccessfulUploadService(tokenCount: 1)
-      let testData = Data(count: 4096)
+      let testData = Data(count: 4_096)
 
       let result = try await service.uploadAssets(
         data: testData,

Tests/MistKitTests/Service/CloudKitServiceUploadTests+Validation.swift

@@ -106,10 +106,10 @@ extension CloudKitServiceUploadTests {
       // Test various valid sizes (CloudKit limit is 15 MB)
       let validSizes = [
         1,  // 1 byte
-        1024,  // 1 KB
-        1024 * 1024,  // 1 MB
-        10 * 1024 * 1024,  // 10 MB
-        15 * 1024 * 1024  // Exactly 15 MB (maximum allowed)
+        1_024,  // 1 KB
+        1_024 * 1_024,  // 1 MB
+        10 * 1_024 * 1_024,  // 10 MB
+        15 * 1_024 * 1_024  // Exactly 15 MB (maximum allowed)
       ]
 
       for size in validSizes {