Skip to content

Commit fffdb31

Browse files
PatrykMisoSumAtrIX
authored andcommitted
feat: improve accessibility (ReVanced#64)
* Label Back button * Mark group section headings as headings Signed-off-by: Patryk Miś <foss@patrykmis.com>
1 parent ee41e31 commit fffdb31

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

app/src/main/java/app/revanced/manager/ui/component/AppScaffold.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ import androidx.compose.material3.*
88
import androidx.compose.runtime.Composable
99
import androidx.compose.ui.Modifier
1010
import androidx.compose.ui.input.nestedscroll.nestedScroll
11+
import androidx.compose.ui.res.stringResource
1112
import androidx.compose.ui.unit.dp
13+
import app.revanced.manager.R
1214

1315
@OptIn(ExperimentalMaterial3Api::class)
1416
@Composable
@@ -47,7 +49,7 @@ fun AppTopBar(
4749
IconButton(onClick = onBackClick) {
4850
Icon(
4951
imageVector = Icons.Default.ArrowBack,
50-
contentDescription = null
52+
contentDescription = stringResource(R.string.back)
5153
)
5254
}
5355
}

app/src/main/java/app/revanced/manager/ui/component/GroupHeader.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import androidx.compose.material3.MaterialTheme
55
import androidx.compose.material3.Text
66
import androidx.compose.runtime.Composable
77
import androidx.compose.ui.Modifier
8+
import androidx.compose.ui.semantics.heading
9+
import androidx.compose.ui.semantics.semantics
810
import androidx.compose.ui.unit.dp
911

1012
@Composable
@@ -16,6 +18,6 @@ fun GroupHeader(
1618
text = title,
1719
color = MaterialTheme.colorScheme.primary,
1820
style = MaterialTheme.typography.labelLarge,
19-
modifier = Modifier.padding(16.dp).then(modifier)
21+
modifier = Modifier.padding(16.dp).semantics { heading() }.then(modifier)
2022
)
2123
}

0 commit comments

Comments
 (0)