Skip to content

Commit c845a90

Browse files
authored
shared.bazelrc: unblock config=remote (#11600)
Adding a MacOS-only linkopt will break when we try to use Linux exec+target via RBE. Remove these flags for now with a TODO to add this into the toolchain level later.
1 parent 39a81f5 commit c845a90

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

shared.bazelrc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,12 @@ common:macos --macos_minimum_os=12.0
164164
common:macos --host_macos_minimum_os=12.0
165165

166166
# Silence noise about -lm -lm which has no functional downside
167-
common:macos --linkopt=-Wl,-no_warn_duplicate_libraries
168-
common:macos --host_linkopt=-Wl,-no_warn_duplicate_libraries
167+
#
168+
# TODO(sluongng): Note that adding linkopt here will break --config=remote since
169+
# we will use Linux exec and target under that config. We should find a better way
170+
# to add this flag into the toolchain level.
171+
# common:macos --linkopt=-Wl,-no_warn_duplicate_libraries
172+
# common:macos --host_linkopt=-Wl,-no_warn_duplicate_libraries
169173

170174
########################
171175
# BES + CACHE + REMOTE #

0 commit comments

Comments
 (0)