Forbid rustdoc warnings in CI (#12420)

* Forbid rustdoc warnings in CI

This commit corrects our handling of rustdoc flags in CI to ensure that
warnings indeed fire. Additionally this changes our flags to pass
`-Dwarnings` to ensure that we have warning-free doc builds when all
features are enabled at least.

There were quite a lot of preexisting issues to fix, so this
additionally goes through and fixes all the warnings that cropped up.

* Update nightly toolchain again

prtest:full

* Update another nightly

* Fix a warning in generated code

Author: alexcrichton

.github/actions/install-rust/action.yml

@@ -32,7 +32,7 @@ runs:
         elif [ "${{ inputs.toolchain }}" = "msrv" ]; then
           echo "version=1.$msrv.0" >> "$GITHUB_OUTPUT"
         elif [ "${{ inputs.toolchain }}" = "wasmtime-ci-pinned-nightly" ]; then
-          echo "version=nightly-2026-01-22" >> "$GITHUB_OUTPUT"
+          echo "version=nightly-2026-01-26" >> "$GITHUB_OUTPUT"
         else
           echo "version=${{ inputs.toolchain }}" >> "$GITHUB_OUTPUT"
         fi

.github/workflows/main.yml

@@ -261,7 +261,7 @@ jobs:
     env:
       MDBOOK_VERSION: 0.4.37
       MDBOOK_LANGTABS_VERSION: 0.1.1
-      RUSTDOCFLAGS: -Dbroken_intra_doc_links --cfg docsrs
+      RUSTDOCFLAGS: -Dwarnings --cfg docsrs
       OPENVINO_SKIP_LINKING: 1
     steps:
     - uses: actions/checkout@v4
@@ -304,11 +304,7 @@ jobs:
           --exclude wasm-spec-interpreter \
           --exclude calculator \
           --all-features
-      env:
-        RUSTDOCFLAGS: --cfg=docsrs
     - run: cargo doc --package cranelift-codegen-meta --document-private-items
-      env:
-        RUSTDOCFLAGS: --cfg=docsrs
 
     # Assemble the documentation, and always upload it as an artifact for
     # inspection on PRs and such.

cranelift/assembler-x64/meta/src/dsl/custom.rs

@@ -16,7 +16,7 @@ pub enum Customization {
     /// Modify how an instruction is emitted into the code buffer.
     Encode,
     /// Modify the instruction mnemonic (see [`crate::dsl::Inst::mnemonic`]);
-    /// this customization is irrelevant if [`CustomOperation::Display`] is also
+    /// this customization is irrelevant if [`Customization::Display`] is also
     /// specified.
     Mnemonic,
     /// Modify how a register allocator visits the operands of an instruction.

cranelift/assembler-x64/meta/src/dsl/encoding.rs

@@ -184,9 +184,9 @@ pub struct Rex {
     /// instruction lists the corresponding hexadecimal value of the opcode byte
     /// with low 3 bits as 000b. In non-64-bit mode, a register code, from 0
     /// through 7, is added to the hexadecimal value of the opcode byte. In
-    /// 64-bit mode, indicates the four bit field of REX.b and opcode[2:0] field
-    /// encodes the register operand of the instruction. “+ro” is applicable
-    /// only in 64-bit mode."
+    /// 64-bit mode, indicates the four bit field of REX.b and `opcode[2:0]`
+    /// field encodes the register operand of the instruction. “+ro” is
+    /// applicable only in 64-bit mode."
     pub opcode_mod: Option<OpcodeMod>,
 }
 
@@ -1173,9 +1173,9 @@ impl Vex {
     }
 
     /// An 8-bit immediate byte is present containing a source register
-    /// specifier in either imm8[7:4] (for 64-bit
-    /// mode) or imm8[6:4] (for 32-bit mode), and instruction-specific payload
-    /// in imm8[3:0].
+    /// specifier in either `imm8[7:4]` (for 64-bit
+    /// mode) or `imm8[6:4]` (for 32-bit mode), and instruction-specific payload
+    /// in `imm8[3:0]`.
     pub fn is4(self) -> Self {
         Self { is4: true, ..self }
     }

cranelift/assembler-x64/meta/src/dsl/format.rs

@@ -591,7 +591,7 @@ impl core::fmt::Display for Extension {
 /// In the future, we might want to model specific EFLAGS bits instead of the
 /// entire EFLAGS register.
 /// Some related discussion in this GitHub issue
-/// https://github.com/bytecodealliance/wasmtime/issues/10298
+/// <https://github.com/bytecodealliance/wasmtime/issues/10298>
 #[derive(Clone, Copy, Debug, PartialEq)]
 pub enum Eflags {
     None,

cranelift/assembler-x64/src/mem.rs

@@ -128,7 +128,7 @@ impl core::fmt::LowerHex for AmodeOffset {
 /// Cranelift, this structure stores an optional [`KnownOffset`]. The following
 /// happens immediately before emission:
 /// - the [`KnownOffset`] is looked up, mapping it to an offset value
-/// - the [`Simm32`] value is added to the offset value
+/// - the [`AmodeOffset`] value is added to the offset value
 #[derive(Copy, Clone, Debug, PartialEq)]
 pub struct AmodeOffsetPlusKnownOffset {
     pub simm32: AmodeOffset,

cranelift/codegen/src/ir/debug_tags.rs

@@ -73,7 +73,7 @@ impl DebugTags {
     /// Set the tags on an instruction, overwriting existing tag list.
     ///
     /// Tags can only be set on call instructions (those for which
-    /// [`crate::Opcode::is_call()`] returns `true`) and on
+    /// [`crate::ir::Opcode::is_call()`] returns `true`) and on
     /// `sequence_point` instructions. This property is checked by the
     /// CLIF verifier.
     pub fn set(&mut self, inst: Inst, tags: impl IntoIterator<Item = DebugTag>) {

cranelift/codegen/src/ir/entities.rs

@@ -57,7 +57,6 @@ impl Block {
 /// - [`f64const`](super::InstBuilder::f64const) for 64-bit float constants
 /// - [`f128const`](super::InstBuilder::f128const) for 128-bit float constants
 /// - [`vconst`](super::InstBuilder::vconst) for vector constants
-/// - [`null`](super::InstBuilder::null) for null reference constants
 ///
 /// Any `InstBuilder` instruction that has an output will also return a `Value`.
 ///

cranelift/codegen/src/ir/exception_table.rs

@@ -129,7 +129,7 @@ impl ExceptionTableData {
     /// `BlockArg::TryCallExn` in the exceptional-return cases, with
     /// types corresponding to native machine words and an arity
     /// corresponding to the number of payload values that the calling
-    /// convention and platform support. (See [`isa::CallConv`] for
+    /// convention and platform support. (See [`CallConv`](crate::isa::CallConv) for
     /// more details.)
     pub fn new(
         sig: SigRef,

cranelift/codegen/src/lib.rs

@@ -74,10 +74,10 @@ pub use crate::machinst::buffer::{
     OpenPatchRegion, PatchRegion,
 };
 pub use crate::machinst::{
-    CallInfo, CompiledCode, Final, MachBuffer, MachBufferDebugTagList, MachBufferFinalized,
-    MachBufferFrameLayout, MachDebugTagPos, MachInst, MachInstEmit, MachInstEmitState, MachLabel,
-    RealReg, Reg, RelocDistance, TextSectionBuilder, VCodeConstant, VCodeConstantData,
-    VCodeConstants, VCodeInst, Writable,
+    CallInfo, CompiledCode, Final, FrameLayout, MachBuffer, MachBufferDebugTagList,
+    MachBufferFinalized, MachBufferFrameLayout, MachDebugTagPos, MachInst, MachInstEmit,
+    MachInstEmitState, MachLabel, RealReg, Reg, RelocDistance, TextSectionBuilder, VCodeConstant,
+    VCodeConstantData, VCodeConstants, VCodeInst, Writable,
 };
 
 mod alias_analysis;