Fix: button animation #1769
Merged
Fix: button animation #1769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@logustra Is it possible to animate elevation using native driver now? |
jayu
approved these changes
Apr 3, 2020
Contributor
There was a problem hiding this comment.
Thank you! @Trancever I just checked and it seems to work with expo 34
https://snack.expo.io/@jaysbytes/react-native-animated-example
|
From #959 (comment), we should be cautious to put a simple |
Contributor
Author
|
@Trancever |
Contributor
|
@logustra I believe it's safe to pass true for iOS cause we are dropping support for RN < 0.60 anyway. |
Trancever
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1678
Test plan
Nothing visual has changed