feat: support flat and elevated mode #3799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
tjaniczek
reviewed
Apr 3, 2023
| }, | ||
| }); | ||
|
|
||
| it('should render Surface with appropriate bg color but without shadow, if mode is set to "flat"', () => { |
Collaborator
There was a problem hiding this comment.
It would be nice to have a test with mode="elevated" too
tjaniczek
approved these changes
Apr 3, 2023
Collaborator
tjaniczek
left a comment
tjaniczek
left a comment
There was a problem hiding this comment.
Tested on devices, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3790
Summary
Related issue
Introducing prop
modeto theSurfacecomponent with two possible optionselevated(default) andflat.The
flatmode indicates theSurfacecomponent will have the background color appropriate to the set level, however, it will not have ashadow.Test plan
New prop
modecovered by unit tests.