Usage of @callstack/react-theme-provider

[souhe]

Replace local theme-provider with @callstack/react-theme-provider

[callstack-bot]

Hey @souhe, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

[satya164]

There is a bug in the implementation. When running the example app, you will notice that the color of the Appbar suddenly changes from purple to teal. This doesn't happen in the material-next branch.

When searching for this teal color in Paper's codebase, I found that it's used here: https://github.com/callstack/react-native-paper/blob/material-next/example/DrawerItems.js#L60, where it's passed as a prop to a component wrapped in withTheme.

From a quick look, the problem seems to be that @callstack/react-theme-provider mutates the theme object by using lodash.merge which changes the primary color to teal for every component which is visible on next re-render. react-native-paper uses the deepmerge module which returns a new object after merging instead of mutation.

[ferrannp]

@souhe how is this going?

[souhe]

@ferran @satya164 I've fixed this bug in theme-provider. This is PR with fix and unit test for the bug - callstack/react-theme-provider#21
After merge, I'll release new version, use it here and this PR should be ready to merge!

[souhe]

@satya164 @ferrannp it's done. We're using fixed version of theme-provider now